Add support for <embed> and <object> containerTypes. #65
Conversation
index.bs
Outdated
| 1. Set |attribution|'s {{TaskAttributionTiming/containerType}}, {{TaskAttributionTiming/containerName}}, {{TaskAttributionTiming/containerSrc}}, and {{TaskAttributionTiming/containerId}} to <code>null</code>. | ||
| 1. If |culpritSettings| is not <code>null</code> | ||
| 1. Let |container| be the |culpritSettings|'s <a>responsible browsing context</a>'s <a>browsing context container</a>. | ||
| 1. If |container| is not <code>null</code>, set |attribution|'s {{containerId}} attribute to the value of |container|'s [=Element/ID=], or <code>null</code> if the ID is unset. |
There was a problem hiding this comment.
Also DOMString nullness problem here.
There was a problem hiding this comment.
Fixed DOMString nullness - I'm not sure if |container| can be null. @domenic ?
There was a problem hiding this comment.
I'm 95% sure it cannot be null. A BC container can have a null nested BC, but if a nested BC exists, then the BC container must exist, I believe.
| </pre> | ||
| 1. Set |attribution|'s {{containerType}} attribute to "<code>frame</code>". | ||
| 1. Set |attribution|'s {{containerName}} attribute to the value of |container|'s <{frame/name}> content attribute, or the empty string if the attribute is absent. | ||
| 1. Set |attribution|'s {{containerSrc}} attribute to the value of |container|'s <{frame/src}> content attribute, or the empty string if the attribute is absent. |
There was a problem hiding this comment.
I wasn't able to get this to link correctly, with the correct formatting. @domenic - any ideas?
There was a problem hiding this comment.
It looks like obsolete elements are intentionally (?) missing linkable <dfn>s for their attributes. The HTML spec itself just using <code>src</code>, see e.g. https://html.spec.whatwg.org/#frames "process frame attributes". So yeah, just doing that here is probably the way to go.
Fixes #52.