Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autopublish failing #729

Closed
marcoscaceres opened this issue Nov 7, 2018 · 7 comments · Fixed by #731 or #732
Closed

Autopublish failing #729

marcoscaceres opened this issue Nov 7, 2018 · 7 comments · Fixed by #731 or #732
Assignees
@mgiuca

Comments

@marcoscaceres
Copy link
Member

Seems we are missing a few alt attributes:
https://lists.w3.org/Archives/Public/public-tr-notifications/2018Oct/0088.html
@mgiuca mgiuca self-assigned this Nov 7, 2018
@mgiuca
Copy link
Collaborator

mgiuca commented Nov 7, 2018

Oh OK. I can deal with that.

@marcoscaceres
Copy link
Member Author

The W3C Folks recently added the ability to get an email when auto-pub fails. @mgiuca, is it ok to add your email to the .travis file? I'm adding myself there too.

@mgiuca
Copy link
Collaborator

mgiuca commented Nov 7, 2018

Sure go ahead.

mgiuca added a commit to mgiuca/manifest that referenced this issue Nov 7, 2018
@mgiuca
Added missing alt attributes to img elements.
aa853e0 
This was blocking W3C autopublish.

Closes w3c#729.
@mgiuca mgiuca mentioned this issue Nov 7, 2018
Merged
5 tasks
mgiuca added a commit that referenced this issue Nov 7, 2018
@mgiuca
Added missing alt attributes to img elements.
46ab2e6 
This was blocking W3C autopublish.

Closes #729.
@mgiuca
Copy link
Collaborator

mgiuca commented Nov 7, 2018

It worked! Kinda...

https://www.w3.org/TR/2018/WD-appmanifest-20181107/

All the new images are broken. For example: https://www.w3.org/TR/2018/WD-appmanifest-20181107/images/icon-safe-zone.svg doesn't exist. Any ideas?

@mgiuca mgiuca reopened this Nov 7, 2018
@marcoscaceres
Copy link
Member Author

Ah, yeah. We need to explicitly add those. Will send another PR.

@marcoscaceres
Copy link
Member Author

To be clear, images need to be included here:
https://github.com/w3c/manifest/blob/gh-pages/ECHIDNA

@mgiuca
Copy link
Collaborator

mgiuca commented Nov 7, 2018

Good thing the images have alt text!

@marcoscaceres marcoscaceres mentioned this issue Nov 7, 2018
Merged
1 task
christianliebel pushed a commit to christianliebel/manifest that referenced this issue May 27, 2020
@mgiuca @christianliebel
Added missing alt attributes to img elements.
7ed38a5 
This was blocking W3C autopublish.

Closes w3c#729.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgiuca mgiuca

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mgiuca @marcoscaceres