Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify shortcut_items should be within scope of scope #1033

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

philloooo
Copy link
Collaborator

@philloooo philloooo commented Mar 3, 2022

closes #1003

This change (choose at least one, delete ones that don't apply):

Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)
Commit message:

(Fill in. If making normative changes, describe exactly what the behavioral
difference will be.)

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

chore:
editorial:
BREAKING CHANGE:
And use none if it's a normative change


Preview | Diff

@dmurph dmurph self-requested a review March 3, 2022 00:44
Copy link
Collaborator

@dmurph dmurph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this cleanup!

@dmurph dmurph merged commit 121f24f into main Apr 6, 2022
@dmurph dmurph deleted the philloooo-patch-1 branch April 6, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shortcut_items uses manifest_url when it should use start_url
3 participants