chore: export some terms needed by Badging #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgiuca
reviewed
Nov 11, 2019
There was a problem hiding this comment.
Cool, thanks for making this change.
Since you added the new term "installed web application", I searched the doc, there are dozens of times where the phrase "installed web application" or "installed" (used as an adjective to describe the installed WA) appear. Could you go through and link all of those to this new term?
Possibly you could move the word "installed" from an alias of "install" to "installed web application".
|
Before I can merge the two defined terms, I need to add support for But I'll link up what I can. |
* export installed web application * export navigation scope
marcoscaceres
force-pushed
the
export
branch
from
b5a854b
to
4307cf3
Compare
|
I think this should be good to go. |
mgiuca
approved these changes
Apr 1, 2020
christianliebel
pushed a commit
to christianliebel/manifest
that referenced
this pull request
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change (choose one):
changes normative sections without changing behavior)
Commit message:
For https://github.com/WICG/badging/pull/57/files#r341902107
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Apr 1, 2020, 11:01 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.