Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible timeout with css-inline-style-dynamic.tentative.html and href-click-3.html #167

Closed
fred-wang opened this issue Nov 4, 2019 · 0 comments · Fixed by web-platform-tests/wpt#20179

Comments

@fred-wang
Copy link

... when MathML is not supported.

external/wpt/mathml/relations/html5-tree/css-inline-style-dynamic.tentative.html
=> Should probably check whether the MathML element actually support the style attributes. Probably with a feature detection to avoid false positive.

mathml/relations/html5-tree/href-click-3.html
=> I wonder if we can make the test complete after the test_driver.click promise is resolved and just set a boolean to indicate success during the handler instead.

fred-wang added a commit to web-platform-tests/wpt that referenced this issue Nov 8, 2019
- css-inline-style-dynamic.tentative.html:
  Verify that MathMLElement.style is defined before using it. Add a
  feature detection for mspace to avoid false positive.

- href-click-3.html: Handle test_driver's click failure and perform a
  second click with a 'bad' HTML target. If href is supported, the test
  would have completed before the 'bad' handler is called. Otherwise,
  the test will complete in that 'bad' handler.

closes w3c/mathml#167
fred-wang added a commit to web-platform-tests/wpt that referenced this issue Nov 8, 2019
- css-inline-style-dynamic.tentative.html:
  Verify that MathMLElement.style is defined before using it. Add a
  feature detection for mspace to avoid false positive.

- href-click-3.html: Handle test_driver's click failure and perform a
  second click with a 'bad' HTML target. If href is supported, the test
  would have completed before the 'bad' handler is called. Otherwise,
  the test will complete in that 'bad' handler.

closes w3c/mathml#167
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 29, 2019
…athML tests:, a=testonly

Automatic update from web-platform-tests
Prevent potential timeout results in 2 MathML tests: (#20179)

- css-inline-style-dynamic.tentative.html:
  Verify that MathMLElement.style is defined before using it. Add a
  feature detection for mspace to avoid false positive.

- href-click-3.html: Handle test_driver's click failure and perform a
  second click with a 'bad' HTML target. If href is supported, the test
  would have completed before the 'bad' handler is called. Otherwise,
  the test will complete in that 'bad' handler.

closes w3c/mathml#167
--

wpt-commits: 5dde82781c5164541167c940f6494608e00477ea
wpt-pr: 20179
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Nov 29, 2019
…athML tests:, a=testonly

Automatic update from web-platform-tests
Prevent potential timeout results in 2 MathML tests: (#20179)

- css-inline-style-dynamic.tentative.html:
  Verify that MathMLElement.style is defined before using it. Add a
  feature detection for mspace to avoid false positive.

- href-click-3.html: Handle test_driver's click failure and perform a
  second click with a 'bad' HTML target. If href is supported, the test
  would have completed before the 'bad' handler is called. Otherwise,
  the test will complete in that 'bad' handler.

closes w3c/mathml#167
--

wpt-commits: 5dde82781c5164541167c940f6494608e00477ea
wpt-pr: 20179
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 30, 2019
…athML tests:, a=testonly

Automatic update from web-platform-tests
Prevent potential timeout results in 2 MathML tests: (#20179)

- css-inline-style-dynamic.tentative.html:
  Verify that MathMLElement.style is defined before using it. Add a
  feature detection for mspace to avoid false positive.

- href-click-3.html: Handle test_driver's click failure and perform a
  second click with a 'bad' HTML target. If href is supported, the test
  would have completed before the 'bad' handler is called. Otherwise,
  the test will complete in that 'bad' handler.

closes w3c/mathml#167
--

wpt-commits: 5dde82781c5164541167c940f6494608e00477ea
wpt-pr: 20179

UltraBlame original commit: 16bb8215eb20fab80bcd75da9db453e283a39424
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 30, 2019
…athML tests:, a=testonly

Automatic update from web-platform-tests
Prevent potential timeout results in 2 MathML tests: (#20179)

- css-inline-style-dynamic.tentative.html:
  Verify that MathMLElement.style is defined before using it. Add a
  feature detection for mspace to avoid false positive.

- href-click-3.html: Handle test_driver's click failure and perform a
  second click with a 'bad' HTML target. If href is supported, the test
  would have completed before the 'bad' handler is called. Otherwise,
  the test will complete in that 'bad' handler.

closes w3c/mathml#167
--

wpt-commits: 5dde82781c5164541167c940f6494608e00477ea
wpt-pr: 20179

UltraBlame original commit: 16bb8215eb20fab80bcd75da9db453e283a39424
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 30, 2019
…athML tests:, a=testonly

Automatic update from web-platform-tests
Prevent potential timeout results in 2 MathML tests: (#20179)

- css-inline-style-dynamic.tentative.html:
  Verify that MathMLElement.style is defined before using it. Add a
  feature detection for mspace to avoid false positive.

- href-click-3.html: Handle test_driver's click failure and perform a
  second click with a 'bad' HTML target. If href is supported, the test
  would have completed before the 'bad' handler is called. Otherwise,
  the test will complete in that 'bad' handler.

closes w3c/mathml#167
--

wpt-commits: 5dde82781c5164541167c940f6494608e00477ea
wpt-pr: 20179

UltraBlame original commit: 16bb8215eb20fab80bcd75da9db453e283a39424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant