Remove definitions/interface for corruptedFrames. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Media WG resolved to remove this field at TPAC. https://www.w3.org/2019/09/19-mediawg-minutes.html#resolution01 Most UAs have not implemented corrupted frames and have no means to do so. Serious corruption will generally produce a decode error. This may may not be logically associated with particular frames. Less serious corruption may produce artifacts in the output, but in most cases it is not feasible for a UA to know that this has occurred.
|
@mounirlamouri, pls review. |
|
+1 |
|
Text LGTM. Only question, and this could be a follow-up, is given that it was implemented by many, should we have a note in the spec that previous versions used to have the attribute? Or does Mozilla and Apple expect to drop this? |
|
Mounir approved offline. |
Closed
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 11, 2019
…lity' r=bzbarsky According to [1], we're going to deprecate this attribute. [1] w3c/media-playback-quality#20 Differential Revision: https://phabricator.services.mozilla.com/D56621 --HG-- extra : moz-landing-system : lando
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 12, 2019
…lity' r=bzbarsky According to [1], we're going to deprecate this attribute. [1] w3c/media-playback-quality#20 Differential Revision: https://phabricator.services.mozilla.com/D56621 UltraBlame original commit: a2bf666e174210a67ea2a6b70957685b58aad0eb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 12, 2019
…lity' r=bzbarsky According to [1], we're going to deprecate this attribute. [1] w3c/media-playback-quality#20 Differential Revision: https://phabricator.services.mozilla.com/D56621 UltraBlame original commit: a2bf666e174210a67ea2a6b70957685b58aad0eb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 12, 2019
…lity' r=bzbarsky According to [1], we're going to deprecate this attribute. [1] w3c/media-playback-quality#20 Differential Revision: https://phabricator.services.mozilla.com/D56621 UltraBlame original commit: a2bf666e174210a67ea2a6b70957685b58aad0eb
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Dec 16, 2019
…lity' r=bzbarsky According to [1], we're going to deprecate this attribute. [1] w3c/media-playback-quality#20 Differential Revision: https://phabricator.services.mozilla.com/D56621
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Jan 10, 2020
Firefox 73 removed support for corruptedVideoFrames; Chrome never actually implemented support for it at all; and it has now been dropped completely from the spec. See https://bugzilla.mozilla.org/show_bug.cgi?id=1602163 and w3c/media-playback-quality#20 and w3c/media-playback-quality@f7cf7b1
|
Blink never implemented corruptedVideoFrames support, right? https://developer.mozilla.org/en-US/docs/Web/API/VideoPlaybackQuality/corruptedVideoFrames#Browser_compatibility and https://github.com/mdn/browser-compat-data/blob/master/api/VideoPlaybackQuality.json#L58-L64 claim that Chrome support was added in Chrome 23, but that appears to be wrong. So I’ve submitted mdn/browser-compat-data@79558e4 to get those updated. If any of that’s wrong, please comment there or here. |
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Jan 10, 2020
Firefox 73 removed support for corruptedVideoFrames; Chrome never actually implemented support for it at all; and it has now been marked as deprecated in the spec. See https://bugzilla.mozilla.org/show_bug.cgi?id=1602163 and w3c/media-playback-quality#20 and w3c/media-playback-quality@f7cf7b1
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Jan 21, 2020
Firefox 73 removed support for corruptedVideoFrames; Chrome never actually implemented support for it at all; and it has now been marked as deprecated in the spec. See https://bugzilla.mozilla.org/show_bug.cgi?id=1602163 and w3c/media-playback-quality#20 and w3c/media-playback-quality@f7cf7b1
ddbeck
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Jan 21, 2020
* Update getVideoPlaybackQuality data for Chrome etc See https://bugs.chromium.org/p/chromium/issues/detail?id=644731#c47 and https://web-confluence.appspot.com/#!/catalog?q=%22getVideoPlaybackQuality%22 * Update Chrome Android getVideoPlaybackQuality data * Update corruptedVideoFrames support data & status Firefox 73 removed support for corruptedVideoFrames; Chrome never actually implemented support for it at all; and it has now been marked as deprecated in the spec. See https://bugzilla.mozilla.org/show_bug.cgi?id=1602163 and w3c/media-playback-quality#20 and w3c/media-playback-quality@f7cf7b1 * Update corruptedVideoFrames Chrome support data See https://github.com/mdn/browser-compat-data/pull/5452/files#r365296590 and https://storage.googleapis.com/chromium-find-releases-static/6c2.html#6c2d803 * Update corruptedVideoFrames Opera Android support See #5452 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media WG resolved to remove this field at TPAC.
https://www.w3.org/2019/09/19-mediawg-minutes.html#resolution01
Most UAs have not implemented corrupted frames and have no means to do
so.
Serious corruption will generally produce a decode error. This may
may not be logically associated with particular frames. Less serious
corruption may produce artifacts in the output, but in most cases it is
not feasible for a UA to know that this has occurred.