Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors and warnings. #251

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Fix errors and warnings. #251

merged 1 commit into from
Jan 30, 2020

Conversation

mounirlamouri
Copy link
Member

This is fixing the following:

  • missing references;
  • normative references on non-normative sections;
  • update HTML51 to HTML;
  • add mandatory [Exposed=Window] tagging;
  • update constructor syntax.

@mounirlamouri
Copy link
Member Author

@wolenetz PTAL. Note that it's including my other PR so I will have to rebase after you merge.

wolenetz
wolenetz requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@wolenetz wolenetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

media-source-respec.html changes approved. Please rebase. I'll look at the index.html shortly so I can provide more complete approval. Thank you!!

wolenetz
wolenetz requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@wolenetz wolenetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mounirlamouri index.html also looks good. Please rebase. I can then squash+merge. Or let me know if you wish for me to rebase it.

@mounirlamouri
Copy link
Member Author

PTAL

wolenetz
wolenetz approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@wolenetz wolenetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this shortly.

@wolenetz wolenetz merged commit 64a30c8 into w3c:gh-pages Jan 30, 2020
@Ms2ger Ms2ger mentioned this pull request Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolenetz wolenetz wolenetz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mounirlamouri @wolenetz