Change track capture rules to match playback more closely. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </p> | ||
| <p> | ||
| A <code><video></code> element can therefore capture a video | ||
| <code>MediaStreamTrack</code> and any number of audio | ||
| <code>MediaStreamTrack</code>s. An <code><audio></code> element | ||
| <code>MediaStreamTrack</code>s. An <code><audio></code> element |
There was a problem hiding this comment.
Some whitespace sneaked in here.
The set of tracks now matches exactly what is present in the source. Tracks that don't have any content are reflected using the "muted" attribute. This allows for capture of media that has a track that is selected, but not currently playing. It also cleanly deals with seeking because the set of tracks doesn't need to change when seeking, just the muted property. We had no good way to handle disabled and muted tracks previously. This corrects that. captureStreamUntilEnded() just waits until playback ends. It isn't affected by source changes or seeking. Also switched canvas capture to capture nothing when not origin-clean.
martinthomson
force-pushed
the
match_playback
branch
from
2f8a114
to
fde201d
Compare
martinthomson
added a commit
that referenced
this pull request
Sep 17, 2015
Change track capture rules to match playback more closely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set of tracks now matches exactly what is present in the source.
Tracks that don't have any content are reflected using the "muted" attribute.
This allows for capture of media that has a track that is selected, but not
currently playing. It also cleanly deals with seeking because the set of tracks
doesn't need to change when seeking, just the muted property.
We had no good way to handle disabled and muted tracks previously. This
corrects that.
captureStreamUntilEnded() just waits until playback ends. It isn't affected
by source changes or seeking.
Also switched canvas capture to capture nothing when not origin-clean.
Closes #10.