-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing track attributes "remote" and "readonly" (see Issue #320). #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
added a commit
that referenced
this pull request
Mar 17, 2016
Removing track attributes "remote" and "readonly" (see Issue #320).
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Feb 25, 2017
Spec reference: http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 removal was in the February 22, 2016'. [#321] Remove track attributes "remote" and "readonly" : w3c/mediacapture-main#321 Intent to Deprecate and Remove : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI BUG=598704 Review-Url: https://codereview.chromium.org/2425703002 Cr-Commit-Position: refs/heads/master@{#452851}
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Feb 25, 2017
…(patchset #10 id:200001 of https://codereview.chromium.org/2425703002/ ) Reason for revert: Failure on webkit_tests: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/23714 external/wpt/mediacapture-streams/MediaStreamTrack-init.https.html Original issue's description: > Remove |remote| and |readonly| members of MediaStreamTrack. > > Spec reference: > http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 > > removal was in the February 22, 2016'. > [#321] Remove track attributes "remote" and "readonly" : > w3c/mediacapture-main#321 > > Intent to Deprecate and Remove : > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI > > BUG=598704 > > Review-Url: https://codereview.chromium.org/2425703002 > Cr-Commit-Position: refs/heads/master@{#452851} > Committed: https://chromium.googlesource.com/chromium/src/+/a72385a6addeb6194d3568beda3f352e07c97260 TBR=jochen@chromium.org,bbudge@chromium.org,drott@chromium.org,esprehn@chromium.org,hongchan@chromium.org,hta@chromium.org,mcasas@chromium.org,miu@chromium.org,peter@chromium.org,scottmg@chromium.org,peary2@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598704 Review-Url: https://codereview.chromium.org/2710213005 Cr-Commit-Position: refs/heads/master@{#452862}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 14, 2017
Spec reference: http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 removal was in the February 22, 2016'. [#321] Remove track attributes "remote" and "readonly" : w3c/mediacapture-main#321 Intent to Deprecate and Remove : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI BUG=598704 Review-Url: https://codereview.chromium.org/2723433002 Cr-Commit-Position: refs/heads/master@{#456639}
dumganhar
pushed a commit
to dumganhar/chromium
that referenced
this pull request
Mar 14, 2017
Spec reference: http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 removal was in the February 22, 2016'. [#321] Remove track attributes "remote" and "readonly" : w3c/mediacapture-main#321 Intent to Deprecate and Remove : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI BUG=598704 Review-Url: https://codereview.chromium.org/2723433002 Cr-Commit-Position: refs/heads/master@{#456639}
jeffcarp
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 23, 2017
… (patchset #5 id:80001 of https://codereview.chromium.org/2723433002/ ) Reason for revert: Temporarily reverting this CL because it causes a perf regression. See http://crbug.com/703605. Will reland once we understand why the regression occurred. Original issue's description: > Remove |remote| and |readonly| members of MediaStreamTrack. > > Spec reference: > http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 > > removal was in the February 22, 2016'. > [#321] Remove track attributes "remote" and "readonly" : > w3c/mediacapture-main#321 > > Intent to Deprecate and Remove : > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI > > BUG=598704 > > Review-Url: https://codereview.chromium.org/2723433002 > Cr-Commit-Position: refs/heads/master@{#456639} > Committed: https://chromium.googlesource.com/chromium/src/+/27c39dbef0b07b7cd62fb2476d0f0836115fe672 TBR=tkent@chromium.org,aelias@chromium.org,alexmos@chromium.org,bbudge@chromium.org,dpranke@chromium.org,drott@chromium.org,esprehn@chromium.org,haraken@chromium.org,hongchan@chromium.org,hta@chromium.org,mcasas@chromium.org,mkwst@chromium.org,peter@chromium.org,rdevlin.cronin@chromium.org,sergeyu@chromium.org,peary2@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=598704 Review-Url: https://codereview.chromium.org/2767963002 Cr-Commit-Position: refs/heads/master@{#459096}
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Mar 24, 2017
… (patchset #5 id:80001 of https://codereview.chromium.org/2723433002/ ) Reason for revert: Temporarily reverting this CL because it causes a perf regression. See http://crbug.com/703605. Will reland once we understand why the regression occurred. Original issue's description: > Remove |remote| and |readonly| members of MediaStreamTrack. > > Spec reference: > http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 > > removal was in the February 22, 2016'. > [#321] Remove track attributes "remote" and "readonly" : > w3c/mediacapture-main#321 > > Intent to Deprecate and Remove : > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI > > BUG=598704 > > Review-Url: https://codereview.chromium.org/2723433002 > Cr-Commit-Position: refs/heads/master@{#456639} > Committed: https://chromium.googlesource.com/chromium/src/+/27c39dbef0b07b7cd62fb2476d0f0836115fe672 TBR=tkent@chromium.org,aelias@chromium.org,alexmos@chromium.org,bbudge@chromium.org,dpranke@chromium.org,drott@chromium.org,esprehn@chromium.org,haraken@chromium.org,hongchan@chromium.org,hta@chromium.org,mcasas@chromium.org,mkwst@chromium.org,peter@chromium.org,rdevlin.cronin@chromium.org,sergeyu@chromium.org,peary2@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=598704 Review-Url: https://codereview.chromium.org/2767963002 Cr-Commit-Position: refs/heads/master@{#459096}
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Mar 31, 2017
Spec reference: http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 removal was in the February 22, 2016'. [#321] Remove track attributes "remote" and "readonly" : w3c/mediacapture-main#321 Intent to Deprecate and Remove : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI BUG=598704 Review-Url: https://codereview.chromium.org/2788593002 Cr-Commit-Position: refs/heads/master@{#460756}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.