Skip to content

Commit

Permalink
Revert of Remove |remote| and |readonly| members of MediaStreamTrack.…
Browse files Browse the repository at this point in the history
… (patchset #5 id:80001 of https://codereview.chromium.org/2723433002/ )

Reason for revert:
Temporarily reverting this CL because it causes a perf regression. See http://crbug.com/703605.

Will reland once we understand why the regression occurred.

Original issue's description:
> Remove |remote| and |readonly| members of MediaStreamTrack.
>
> Spec reference:
> http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1
>
> removal was in the February 22, 2016'.
> [#321] Remove track attributes "remote" and "readonly" :
> w3c/mediacapture-main#321
>
> Intent to Deprecate and Remove :
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI
>
> BUG=598704
>
> Review-Url: https://codereview.chromium.org/2723433002
> Cr-Commit-Position: refs/heads/master@{#456639}
> Committed: https://chromium.googlesource.com/chromium/src/+/27c39dbef0b07b7cd62fb2476d0f0836115fe672

TBR=tkent@chromium.org,aelias@chromium.org,alexmos@chromium.org,bbudge@chromium.org,dpranke@chromium.org,drott@chromium.org,esprehn@chromium.org,haraken@chromium.org,hongchan@chromium.org,hta@chromium.org,mcasas@chromium.org,mkwst@chromium.org,peter@chromium.org,rdevlin.cronin@chromium.org,sergeyu@chromium.org,peary2@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=598704

Review-Url: https://codereview.chromium.org/2767963002
Cr-Commit-Position: refs/heads/master@{#459096}
  • Loading branch information
guidou authored and jeffcarp committed Mar 23, 2017
1 parent 8bb0b76 commit 5a391c7
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions mediacapture-streams/MediaStreamTrack-init.https.html
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ <h1 class="instructions">Description</h1>
readonly attribute boolean muted;\
attribute EventHandler onmute;\
attribute EventHandler onunmute;\
readonly attribute boolean _readonly;\
readonly attribute boolean remote;\
readonly attribute MediaStreamTrackState readyState;\
attribute EventHandler onended;\
attribute EventHandler onoverconstrained;\
Expand Down

0 comments on commit 5a391c7

Please sign in to comment.