Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove oldList and make it clear that groupId scope is the document #617

Merged
merged 1 commit into from Sep 26, 2019
Merged

Remove oldList and make it clear that groupId scope is the document #617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 1 addition & 16 deletions getusermedia.html
View file
Open in desktop
Expand Up @@ -2913,13 +2913,6 @@ <h2>Methods</h2>
<li>
<p>Let <var>resultList</var> be an empty list.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make "If [[storedDeviceList]] is not null, then let resultList be a copy of [[storedDeviceList]], and jump to the step labeled Complete Enumeration." say to do a deep copy instead of a copy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could but this is not related to this particular issue.
This would partially fix #620.

</li>
<li>
<p>If this method has been called previously within this
browsing session, let <var>oldList</var> be the list of
<code><a>MediaDeviceInfo</a></code> objects that was
produced at that call (<var>resultList</var>); otherwise,
let <var>oldList</var> be an empty list.</p>
</li>
<li>
<p>Probe the User Agent for available media devices, and
run the following sub steps for each discovered device,
Expand All @@ -2941,13 +2934,6 @@ <h2>Methods</h2>
<code>"microphone"</code>, abort these steps and
continue with the next device (if any).</p>
</li>
<li>
<p>If <var>device</var> is represented by a
<code><a>MediaDeviceInfo</a></code> object in
<var>oldList</var>, append that object to
<var>resultList</var>, abort these steps and continue
with the next device (if any).</p>
</li>
<li>
<p>Let <var>deviceInfo</var> be a new
<code><a>MediaDeviceInfo</a></code> object to
Expand All @@ -2966,8 +2952,7 @@ <h2>Methods</h2>
</li>
<li>
<p>If <var>device</var> belongs to the same physical
device as a device already represented in
<var>oldList</var> or <var>resultList</var>,
device as a device already represented for <var>document</var>,
initialize <var>deviceInfo</var>'s
<code><a data-link-for=
"MediaDeviceInfo">groupId</a></code> member to the
Expand Down