Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define behavior for all bitsPerSecond attributes #175

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Define behavior for all bitsPerSecond attributes #175

merged 1 commit into from
Aug 2, 2019

Conversation

Pehrsons
Copy link
Collaborator

Fixes #169.

@Pehrsons
Copy link
Collaborator Author

Note that the first commit in this PR is a squash of PR #171, so consider it a dependency.

Find the diff to be reviewed at 6112e29.

jan-ivar
jan-ivar approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@jan-ivar jan-ivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

MediaRecorder.bs Outdated Show resolved Hide resolved
MediaRecorder.bs Outdated Show resolved Hide resolved
@jan-ivar
Copy link
Member

jan-ivar commented Jul 8, 2019

@armax00 PTAL

@armax00
Copy link

armax00 commented Jul 12, 2019

lgtm for me too. I'll file a bug on Chromium for fixing the behavior, thanks @jan-ivar for checking.

@Pehrsons
Copy link
Collaborator Author

Pehrsons commented Aug 2, 2019

Rebased. ping @jan-ivar

@jan-ivar jan-ivar merged commit e17767b into w3c:master Aug 2, 2019
@Pehrsons Pehrsons deleted the bitratedefaults branch August 6, 2019 10:26
aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 3, 2023
@beaufortfrancois
MediaRecorder: Clamp video & audio bit rate only if bitsPerSecond is set
99244e2 
This CL make sure audioBitsPerSecond and videoBitsPerSecond from
MediaRecorder are clamped only when constructor option bitsPerSecond is
set.

Spec: w3c/mediacapture-record#175
Bug: 1423413

Change-Id: Ib4893ed8ba7704213733e25b3b385c170be2182f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4352829
Reviewed-by: Markus Handell <handellm@google.com>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1125270}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-ivar jan-ivar jan-ivar approved these changes

Assignees
No one assigned
Labels
Editors can integrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What are the default bitrate attribute values?
4 participants
@Pehrsons @jan-ivar @armax00 @aboba