-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micro draft of getSupportedTypes() #64
Conversation
Static methods can return promises, here are two examples I found by grepping Blink: However, in this case it seems odd that you can synchronously ask if a type is supported, but asking for the supported types is async. What kind of implementation would actually have this restriction? In other words, can't getSupportedTypes also be sync? |
An example: H264 is supported in Chrome/Blink in all cases in Sw and, for certain platforms and hardware configurations, by a encode accelerator. |
so that MIME types closer to the beginning have a larger probability | ||
of being supported by encode accelerators. | ||
<div> | ||
<em>Return type:</em> <code>sequence<DOMString></code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It returns a promise, not a sequence directly. Wording more in the style of https://notifications.spec.whatwg.org/#dom-notification-requestpermission would be nice :)
Ah, the order tells you additional information, I didn't read very carefully. It makes sense, concept LGTM. |
BTW, do you have someone to more carefully review spec changes, or am I it here? |
2bd6ecf
to
952d389
Compare
952d389
to
33a5768
Compare
Too many rebases :) |
@foolip can you take a look at the proposed method and let me know what you think, if it's pro forma etc?
Also, can a function be static and return a Promise<> ? :)
Relates to #59.