Skip to content
This repository has been archived by the owner on Nov 11, 2019. It is now read-only.

20 accept content attr globally #40

Merged
merged 2 commits into from
May 24, 2017
Merged

Conversation

chaals
Copy link
Collaborator

@chaals chaals commented May 19, 2017

fix #20
fix #38
fix #39

Changes the algorithm for finding values, to add @content, and make data/meter/time default to their text content if there is no attribute to use.

Re-work the content models and examples to take account of this.

And note it in the changes section

chaals added 2 commits May 19, 2017 04:12
see #20, #38, #39

Note that if there is a `content` attribute is is selected **in
preference** to another specific attribute, including `src` and `href`
reordered to cover the fact that `@content` trumps everything else, and
added examples to show the interaction.
@chaals chaals requested a review from iherman May 19, 2017 02:50
@danbri danbri merged commit 50c3335 into gh-pages May 24, 2017
@msporny
Copy link
Member

msporny commented May 24, 2017

As @Hixie mentioned in #20 - "@content fared poorly in usability studies.", so my +1 to add it is now a +0. Do we either have 1) Data from @Hixie noting the usability studies (doubtful, as Google has not released this data to the public AFAIK), or 2) Demonstration that "@content" is being used across X million sites in Microdata markup.

If we don't have data for either, we're just flying by the seat of our pants (which is usually a bad thing to do spec-wise).

There is another option here, which is to fix the schema.org examples.

@gkellogg
Copy link
Member

Does Microdata need to say something about the HTML content model being updated to allow the @content attribute to be used universally?

Tests should probably look for potential interference between @content and @src, @href, @data, @value, and @datetime.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants