Skip to content

Commit

Permalink
Changed time-signature-unit to use an enum with defined values.
Browse files Browse the repository at this point in the history
This fixes #328. Previously we used an open-ended text field
to describe the allowed values for time-signature-unit, and
now we use a proper enum.
  • Loading branch information
adrianholovaty committed Apr 9, 2024
1 parent 4a14b95 commit fabcc1d
Show file tree
Hide file tree
Showing 3 changed files with 134 additions and 2 deletions.
74 changes: 73 additions & 1 deletion docgenerator/data.json
Expand Up @@ -3246,7 +3246,7 @@
"slug": "time-signature-unit",
"schema": 1,
"object_type": 4,
"description": "1, 2, 4, 8, 16"
"description": ""
}
},
{
Expand Down Expand Up @@ -6426,6 +6426,78 @@
"description": ""
}
},
{
"model": "spec.jsonobjectenum",
"pk": 57,
"fields": {
"parent": 129,
"name": "1",
"description": ""
}
},
{
"model": "spec.jsonobjectenum",
"pk": 58,
"fields": {
"parent": 129,
"name": "2",
"description": ""
}
},
{
"model": "spec.jsonobjectenum",
"pk": 59,
"fields": {
"parent": 129,
"name": "4",
"description": ""
}
},
{
"model": "spec.jsonobjectenum",
"pk": 60,
"fields": {
"parent": 129,
"name": "8",
"description": ""
}
},
{
"model": "spec.jsonobjectenum",
"pk": 61,
"fields": {
"parent": 129,
"name": "16",
"description": ""
}
},
{
"model": "spec.jsonobjectenum",
"pk": 62,
"fields": {
"parent": 129,
"name": "32",
"description": ""
}
},
{
"model": "spec.jsonobjectenum",
"pk": 63,
"fields": {
"parent": 129,
"name": "64",
"description": ""
}
},
{
"model": "spec.jsonobjectenum",
"pk": 64,
"fields": {
"parent": 129,
"name": "128",
"description": ""
}
},
{
"model": "spec.exampledocument",
"pk": 1,
Expand Down
52 changes: 51 additions & 1 deletion docs/mnx-reference/objects/time-signature-unit/index.html
Expand Up @@ -52,11 +52,61 @@ <h1>The time signature unit object</h1>
<p><b>Type:</b> Number</p>


1, 2, 4, 8, 16




<h2>Allowed values:</h2>

<table>
<thead>
<tr>
<th>Value</th>
<th>Description</th>
</tr>
</thead>

<tr>
<td><nobr><b>1</b></nobr></td>
<td></td>
</tr>

<tr>
<td><nobr><b>128</b></nobr></td>
<td></td>
</tr>

<tr>
<td><nobr><b>16</b></nobr></td>
<td></td>
</tr>

<tr>
<td><nobr><b>2</b></nobr></td>
<td></td>
</tr>

<tr>
<td><nobr><b>32</b></nobr></td>
<td></td>
</tr>

<tr>
<td><nobr><b>4</b></nobr></td>
<td></td>
</tr>

<tr>
<td><nobr><b>64</b></nobr></td>
<td></td>
</tr>

<tr>
<td><nobr><b>8</b></nobr></td>
<td></td>
</tr>

</table>



Expand Down
10 changes: 10 additions & 0 deletions docs/mnx-schema.json
Expand Up @@ -687,6 +687,16 @@
"$ref": "#/$defs/positive-integer"
},
"unit": {
"enum": [
1,
2,
4,
8,
16,
32,
64,
128
],
"type": "integer"
}
},
Expand Down

0 comments on commit fabcc1d

Please sign in to comment.