Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smufl attribute to more percussion child elements #403

Closed
mdgood opened this issue May 7, 2021 · 0 comments · Fixed by #404
Closed

Add smufl attribute to more percussion child elements #403

mdgood opened this issue May 7, 2021 · 0 comments · Fixed by #404

Comments

@mdgood
Copy link

mdgood commented May 7, 2021

Although some child elements of the <percussion> element have a smufl attribute, such as <glass>, others do not. In particular, the <effect>, <membrane>, <metal>, <timpani>, and <wood> elements do not have smufl attributes, even though there are SMuFL stylistic alternates for at least one of their element values.

This means that we cannot capture the SMuFL stylistic alternate being used without resorting to the <other-percussion> element and thus losing semantics that could be captured.

Adding the smufl attribute would let us keep the full encoding of the semantics while also encoding the exact SMuFL glyph being used.

@mdgood mdgood changed the title Add smufl attribute to effect, membrane, metal, and wood elements Add smufl attribute to more percussion child elements May 7, 2021
@mdgood mdgood added this to the V4.0 milestone May 7, 2021
@mdgood mdgood linked a pull request May 7, 2021 that will close this issue
mdgood pushed a commit that referenced this issue May 10, 2021
mdgood pushed a commit that referenced this issue May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant