Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix coordinate system enum #56

Merged
merged 1 commit into from Mar 12, 2018
Merged

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Mar 12, 2018

@kenchris
Copy link
Contributor

kenchris commented Mar 12, 2018

That comment says

The enum LocalCoordinateSystem is defined in each of the motion sensor spec - it should be defined just once, and referenced from other specs.

This is just adding a namespace (not that common in other specs) and it becomes as long as the worst Java APIs :-(

Can't we move it to the Generic Sensor spec instead and keep the name?

@dontcallmedom

@anssiko anssiko merged commit 9df4bf9 into gh-pages Mar 12, 2018
@anssiko anssiko deleted the prefix_coordinate_system_enum branch March 12, 2018 12:51
@kenchris
Copy link
Contributor

Why no response on my comment? :-)

@anssiko
Copy link
Member Author

anssiko commented Mar 12, 2018

@kenchris, the local coordinate system concept applies only to spatial sensors, and not all sensors that extend the Generic Sensor API. Enums are not web-exposed, so verbose enum names do not cause any ergonomics issues as in Java APIs.

@kenchris
Copy link
Contributor

kenchris commented Mar 12, 2018

Well, they will be exposed in TypeScript project for intellisense :-) These will most likely be generated from Web IDL (Microsoft has work ongoing on making that happen), which means you will also spread these over your code (You add type declarations when using TS) - so yes, this might actually pose a real problem.

Though they only apply to some sensors, I don't see why they cannot be in the generic spec. They might be useful for future specs down the road. You can just add a Spatial Sensors section and maybe make it optional to implement unless you implement some of the derivative specs

Honry pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 13, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 15, 2018
…eSystem enum., a=testonly

Automatic update from web-platform-testsorientation-sensor: Rename LocalCoordinateSystem enum. (#9975)

Call it `OrientationSensorLocalCoordinateSystem` per
w3c/orientation-sensor#56.

wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa
wpt-pr: 9975
wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa
wpt-pr: 9975
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 2, 2019
…eSystem enum., a=testonly

Automatic update from web-platform-testsorientation-sensor: Rename LocalCoordinateSystem enum. (#9975)

Call it `OrientationSensorLocalCoordinateSystem` per
w3c/orientation-sensor#56.

wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa
wpt-pr: 9975
wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa
wpt-pr: 9975

UltraBlame original commit: 545c0ad0a16ed7458f4fdd11be6a0b435044417d
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 2, 2019
…eSystem enum., a=testonly

Automatic update from web-platform-testsorientation-sensor: Rename LocalCoordinateSystem enum. (#9975)

Call it `OrientationSensorLocalCoordinateSystem` per
w3c/orientation-sensor#56.

wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa
wpt-pr: 9975
wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa
wpt-pr: 9975

UltraBlame original commit: 545c0ad0a16ed7458f4fdd11be6a0b435044417d
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 2, 2019
…eSystem enum., a=testonly

Automatic update from web-platform-testsorientation-sensor: Rename LocalCoordinateSystem enum. (#9975)

Call it `OrientationSensorLocalCoordinateSystem` per
w3c/orientation-sensor#56.

wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa
wpt-pr: 9975
wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa
wpt-pr: 9975

UltraBlame original commit: 545c0ad0a16ed7458f4fdd11be6a0b435044417d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants