Fix for WebRTC 1.0 Issue 391 A-D in DTMF (and change log additions) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following issue was filed against WebRTC 1.0 relating to DTMF support: w3c/webrtc-pc#391 It was resolved in the following PR: w3c/webrtc-pc#402
aboba
changed the title
|
There is no reason not to support A-D. Support for A-D DTMF tone generation requires no additional code. These codes, even though they are not present on standard DTMF keypads, are still used by some of the IVR systems for automated entry. It makes no sense to remove already implemented features with no discussion. It probably makes more sense to harmonize in the opposite direction (i.e. change the IETF draft). |
|
I agree there's no reason not to support. Takes more effort to not support (mostly). However, this is about mandatory support of legacy devices and nothing stops implementations doing the full support (which they likely will if they intend to support DTMF). I know ortc-lib will support it for example. |
robin-raymond
pushed a commit
that referenced
this pull request
Dec 1, 2015
Fix for WebRTC 1.0 Issue 391 A-D in DTMF (and change log additions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issue was filed against WebRTC 1.0 relating to DTMF support:
w3c/webrtc-pc#391
It was resolved in the following PR:
w3c/webrtc-pc#402