Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify merchant that payment method (possibly including the billing address) changed in payment handler. #318

Merged
merged 6 commits into from Sep 14, 2018
Merged

Notify merchant that payment method (possibly including the billing address) changed in payment handler. #318

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d24b5cf
PaymentRequestEvent.changePaymentMethod(methodName, methodDetails).
rsolomakhin Sep 12, 2018
4570354
Generic payment method errors instead of billing address specific.
rsolomakhin Sep 12, 2018
5116da1
Address comments.
rsolomakhin Sep 12, 2018
2c69862
Use PaymentCurrencyAmount type total
rsolomakhin Sep 12, 2018
f25d42f
Do not use a dictionary as an attribute.
rsolomakhin Sep 13, 2018
3525c7a
Make methodDetails optional.
rsolomakhin Sep 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 10 additions & 9 deletions index.html
View file
Open in desktop
Expand Up @@ -1157,9 +1157,9 @@ <h2>
The <dfn>PaymentMethodChangeResponse</dfn>
</h2>
<p>
The PaymentMethodChangeResponse contains the udpated total
(optionally with modifiers) and possible errors resulting from user
selecting an payment method within a payment handler.
The <code>PaymentMethodChangeResponse</code> contains the updated
total (optionally with modifiers) and possible errors resulting from
user selection of a payment method within a payment handler.
</p>
<pre class="idl">
dictionary PaymentMethodChangeResponse {
Expand All @@ -1183,19 +1183,20 @@ <h2>
<dfn>total</dfn> member
</h2>
<p>
Updated total based on the changed payment method. This can change,
for example, in VAT calculations based on the billing address
associated with the payment method.
Updated total based on the changed payment method. The total can
change, for example, because the billing address of the payment
method selected by the user changes the Value Added Tax (VAT).
</p>
</section>
<section>
<h2>
<dfn>modifiers</dfn> member
</h2>
<p>
Updated modifiers based on the changed payment method. These can
change, for example, in VAT calculations based on the billing
address associated with the payment method.
Updated modifiers based on the changed payment method. For example,
if the overall total has increased by €1.00 based on the billing
address, then the totals specified in each of the modifiers should
also increase by €1.00.
</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give a more specific example of a changed modifier?

</section>
<section>
Expand Down