editorial: relocate Algorithms section #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noting that no content has changed. This is just so people know what is going on and why stuff moved. |
ianbjacobs
approved these changes
May 17, 2018
|
Yeah, might be a good idea. Will update. |
In order to do response.retry(), the Algorithms section needs to move to PaymentRequest. This is because the some algorithms are very specific to PaymentRequest. Eventually, we might end up with shared algorithms between PaymentRequest and PaymentResponse.
marcoscaceres
force-pushed
the
eds_move_algos
branch
from
f55c117
to
79d929f
Compare
marcoscaceres
added a commit
that referenced
this pull request
May 21, 2018
This reverts commit e968518.
|
I reverted this temporally, as it made a bit of a mess with the existing PRs. Once the other PRs get merged, I'll send again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to do response.retry(), the Algorithms section needs to move
to PaymentRequest. This is because the some algorithms are very specific
to PaymentRequest. Eventually, we might end up with shared algorithms
between PaymentRequest and PaymentResponse.
Preview | Diff