fix: give PaymentMethodChangeEventInit defaults #771
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added gecko bug. Will write a test to make sure it defaults correctly. |
|
I'm implementing all of PaymentMethodChangeEvent in this WebKit bug, so I'll update my patch with this change before landing. |
aestes
approved these changes
Aug 30, 2018
domenic
approved these changes
Aug 30, 2018
marcoscaceres
changed the title
|
Tests will be upstreamed from Gecko once the Firefox patch lands. |
|
Ok, sent request to merge on the Firefox side and asked our awesome tech writers to document this change. |
|
Spec is republished on TR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #770
The following tasks have been completed:
Implementation commitment:
Optional, Impact on Payment Handler spec?
Preview | Diff