Refactor, shuffle order, improve navigation #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-timeline into marcoscaceres-patch-1
- Moved filter method into processing - Made filter method take a buffer - Updated ObserverEntryList definitions to call filter method - More logical order to the sections - tidy formatted
|
/cc @yoavweiss @toddreifsteck @JosephPecoraro @plehegar for a sanity check.. :) |
entryTypes is marked as required in WebIDL. Closes #73.
|
LGTM |
|
@plehegar can you please take a quick pass? :) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A whole bunch of editorial + cleanup updates. No functional changes.
The diff is scary looking, but mostly due to tidy (re)formatting. Take a look at the preview instead:
https://cdn.rawgit.com/w3c/performance-timeline/b816729b692fb136a3f12957ac298d9c5652311b/index.html