Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari returns different results for current permission state #278

Closed
miketaylr opened this issue Aug 30, 2021 · 5 comments · Fixed by #380
Closed

Safari returns different results for current permission state #278

miketaylr opened this issue Aug 30, 2021 · 5 comments · Fixed by #380
Assignees

Comments

@miketaylr
Copy link
Member

miketaylr commented Aug 30, 2021

Safari is the only known UA that returns different results from this algorithm for different settings objects with the same origin. We should test which of the several possible settings objects it uses.

@miketaylr miketaylr self-assigned this Oct 25, 2021
@miketaylr miketaylr changed the title Tracking issue for Safari returning different results for current permission state Safari returns different results for current permission state Oct 25, 2021
miketaylr added a commit to miketaylr/permissions that referenced this issue Oct 25, 2021
marcoscaceres added a commit that referenced this issue Oct 26, 2021
* Chore: Link issue #278 using magical ReSpec issue feature

* Update index.html

Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
github-actions bot added a commit that referenced this issue Oct 26, 2021
SHA: ebf3e0e
Reason: push, by @marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@miketaylr
Copy link
Member Author

@jyasskin do you have any additional context on this one? Having a hard time parsing it. :)

@marcoscaceres marcoscaceres self-assigned this Feb 25, 2022
@jyasskin
Copy link
Member

Oh, yes, from https://www.w3.org/TR/permissions/#reading-current-states. When I poked at this several years ago, it appeared possible to have different iframes or tabs from the same origin that had different states for a given permission. For example, one could have the permission "granted" while the other had it "denied". In cases where those could directly manipulate each other's DOM (i.e. iframes and tabs with an opener relationship), that means that calling otherframe.window.permissions.query(...) could return something different from window.permissions.query(...), and similarly for calling a cross-frame function that then calls permissions.query(...). I never wrote the tests to figure out exactly what happened, and the landscape has changed enough since then that my claim about Safari might not even be true anymore.

@miketaylr
Copy link
Member Author

Thank you! I'll do some testing to see if anything like this still exists, and close it out otherwise.

@miketaylr
Copy link
Member Author

OK, I made the world's worst test page at https://miketaylr.com/misc/permission-window.html.

I'm not able to create a scenario where an iframe, or a new window has a permission state that isn't synced with the permission state of all other frames for the origin. I think we can just close this out and remove the note from the spec.

miketaylr added a commit to miketaylr/permissions that referenced this issue May 25, 2022
I propose to close it as invalid.
@marcoscaceres
Copy link
Member

WebKit has some of the API itself implemented, so (in theory) we will pick up an interop differences with testing.

marcoscaceres pushed a commit that referenced this issue May 27, 2022
I propose to close it as invalid.
github-actions bot added a commit that referenced this issue May 27, 2022
SHA: 698e614
Reason: push, by @marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants