Switch PermissionName to DOMString #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we're going to want to write some patches for Chromium, WebKit, and Gecko as well. |
miketaylr
reviewed
Feb 4, 2022
4 tasks
Nah, the point of this change is that they can just use an enum... so nothing need to change in browsers. The change is fully backwards compatible. |
marcoscaceres
force-pushed
the
use_DOMString
branch
from
e0dd978
to
c80775e
Compare
|
Even better. |
marcoscaceres
force-pushed
the
use_DOMString
branch
3 times, most recently
from
3b164fd
to
f687465
Compare
miketaylr
reviewed
Feb 9, 2022
miketaylr
approved these changes
Feb 9, 2022
marcoscaceres
force-pushed
the
use_DOMString
branch
from
f687465
to
8df1069
Compare
marcoscaceres
force-pushed
the
use_DOMString
branch
from
8df1069
to
571acf3
Compare
github-actions bot
added a commit
that referenced
this pull request
Feb 14, 2022
SHA: e8a070f Reason: push, by @marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #350, #351, and the actual Powerful Features Registry.
Closes #319
Closes #314
Closes #263
Preview | Diff