Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to /TR #176

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Link to /TR #176

merged 2 commits into from
Jun 11, 2020

Conversation

xfq
Copy link
Member

@xfq xfq commented Feb 1, 2020

@xfq xfq requested a review from tidoust February 1, 2020 14:04
@beaufortfrancois
Copy link
Collaborator

@tidoust Can you confirm this PR is valid?

Copy link
Member

@tidoust tidoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but see online comment.

index.bs Outdated
@@ -4,6 +4,8 @@ Shortname: picture-in-picture
Level: 1
Status: ED
ED: https://w3c.github.io/picture-in-picture/
TR: https://www.w3.org/TR/picture-in-picture/
Previous Version: https://www.w3.org/TR/2020/WD-picture-in-picture-20200130/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't necessarily include a link to the previous published Working Draft in the Editor's Draft (that's the sort of thing that are tedious to maintain and may easily become wrong)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just removed this line.

@beaufortfrancois beaufortfrancois merged commit 84ed99d into master Jun 11, 2020
@beaufortfrancois
Copy link
Collaborator

I've merged as feedback has been addressed. Thank you @xfq!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants