Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move single directional touch-action values to the extension spec #238

Merged
merged 2 commits into from
Apr 3, 2018
Merged

Move single directional touch-action values to the extension spec #238

merged 2 commits into from
Apr 3, 2018

Conversation

NavidZ
Copy link
Member

@NavidZ NavidZ commented Mar 29, 2018

No description provided.

@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Mar 29, 2018
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Mar 29, 2018
@NavidZ @chromium-wpt-export-bot
Fix up the touch-action tests
f59b601 
Move the touch-action: pan-left/right/up/down tests to
the next version of the spec.
w3c/pointerevents#238

Bug: 826726
Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71
@patrickhlauke
Copy link
Member

can you just remind me of the rationale for this? i lost track of where we discussed it / the reasons for moving

@NavidZ
Copy link
Member Author

NavidZ commented Apr 3, 2018

This was actually implemeted in Chrome two years ago. @smaug---- told that Firefox is not going to be able to have this any time soon. That's why we said okay let's move it to the extension. What do you think we should do?

@patrickhlauke
Copy link
Member

Ah, gotcha. That's fine, it just slipped my mind why we did this, but makes sense to move it to extension. I assume the situation is similar for Edge then.

@patrickhlauke patrickhlauke merged commit 17647a3 into w3c:gh-pages Apr 3, 2018
aarongable pushed a commit to chromium/chromium that referenced this pull request Apr 4, 2018
@NavidZ
Fix up the touch-action tests
8c7af6e 
Move the touch-action: pan-left/right/up/down tests to
the next version of the spec.
w3c/pointerevents#238

Bug: 826726
Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71
Reviewed-on: https://chromium-review.googlesource.com/984736
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548078}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 4, 2018
@NavidZ @chromium-wpt-export-bot
Fix up the touch-action tests
840ff05 
Move the touch-action: pan-left/right/up/down tests to
the next version of the spec.
w3c/pointerevents#238

Bug: 826726
Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71
Reviewed-on: https://chromium-review.googlesource.com/984736
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548078}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 4, 2018
@NavidZ @chromium-wpt-export-bot
Fix up the touch-action tests
48df374 
Move the touch-action: pan-left/right/up/down tests to
the next version of the spec.
w3c/pointerevents#238

Bug: 826726
Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71
Reviewed-on: https://chromium-review.googlesource.com/984736
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548078}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 15, 2018
@NavidZ @jgraham
Bug 1449988 [wpt PR 10241] - Fix up the touch-action tests, a=testonly
178a495 
Automatic update from web-platform-testsFix up the touch-action tests

Move the touch-action: pan-left/right/up/down tests to
the next version of the spec.
w3c/pointerevents#238

Bug: 826726
Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71
Reviewed-on: https://chromium-review.googlesource.com/984736
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548078}

wpt-commits: 48df374681de1672f3826915161f6c2e12ec4d59
wpt-pr: 10241
wpt-commits: 48df374681de1672f3826915161f6c2e12ec4d59
wpt-pr: 10241
@lpd-au
Copy link

lpd-au commented Jun 11, 2019

Given the extra time, will this be included again for level 3?

@NavidZ
Copy link
Member Author

NavidZ commented Jun 11, 2019

@lpd-au that's the plan.

gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 2, 2019
@marco-c
Bug 1449988 [wpt PR 10241] - Fix up the touch-action tests, a=testonly
1622adf 
Automatic update from web-platform-testsFix up the touch-action tests

Move the touch-action: pan-left/right/up/down tests to
the next version of the spec.
w3c/pointerevents#238

Bug: 826726
Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71
Reviewed-on: https://chromium-review.googlesource.com/984736
Reviewed-by: Dave Tapuska <dtapuskachromium.org>
Commit-Queue: Navid Zolghadr <nzolghadrchromium.org>
Cr-Commit-Position: refs/heads/master{#548078}

wpt-commits: 48df374681de1672f3826915161f6c2e12ec4d59
wpt-pr: 10241
wpt-commits: 48df374681de1672f3826915161f6c2e12ec4d59
wpt-pr: 10241

UltraBlame original commit: 366210378fc547535f3dd9fe7add2e1a8c70541a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 2, 2019
@marco-c
Bug 1449988 [wpt PR 10241] - Fix up the touch-action tests, a=testonly
353bfb8 
Automatic update from web-platform-testsFix up the touch-action tests

Move the touch-action: pan-left/right/up/down tests to
the next version of the spec.
w3c/pointerevents#238

Bug: 826726
Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71
Reviewed-on: https://chromium-review.googlesource.com/984736
Reviewed-by: Dave Tapuska <dtapuskachromium.org>
Commit-Queue: Navid Zolghadr <nzolghadrchromium.org>
Cr-Commit-Position: refs/heads/master{#548078}

wpt-commits: 48df374681de1672f3826915161f6c2e12ec4d59
wpt-pr: 10241
wpt-commits: 48df374681de1672f3826915161f6c2e12ec4d59
wpt-pr: 10241

UltraBlame original commit: 366210378fc547535f3dd9fe7add2e1a8c70541a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 2, 2019
@marco-c
Bug 1449988 [wpt PR 10241] - Fix up the touch-action tests, a=testonly
255f72b 
Automatic update from web-platform-testsFix up the touch-action tests

Move the touch-action: pan-left/right/up/down tests to
the next version of the spec.
w3c/pointerevents#238

Bug: 826726
Change-Id: Icab0e439e0c2281f0c9fc78eec0a41a044f37f71
Reviewed-on: https://chromium-review.googlesource.com/984736
Reviewed-by: Dave Tapuska <dtapuskachromium.org>
Commit-Queue: Navid Zolghadr <nzolghadrchromium.org>
Cr-Commit-Position: refs/heads/master{#548078}

wpt-commits: 48df374681de1672f3826915161f6c2e12ec4d59
wpt-pr: 10241
wpt-commits: 48df374681de1672f3826915161f6c2e12ec4d59
wpt-pr: 10241

UltraBlame original commit: 366210378fc547535f3dd9fe7add2e1a8c70541a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhlauke patrickhlauke patrickhlauke approved these changes

@mustaqahmed mustaqahmed Awaiting requested review from mustaqahmed

@smaug---- smaug---- Awaiting requested review from smaug----

@dtapuska dtapuska Awaiting requested review from dtapuska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NavidZ @patrickhlauke @lpd-au