Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand explanation for non-coalesced events #379

Merged
merged 12 commits into from
Jul 7, 2021

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented May 23, 2021

  • a user agents may coalesce events not just if the position is updated, but any of the attributes (as it's not just position changes that can result in an overwhelmingly large number of events)
  • tweaked the matching sentence in the pointerrawupdate slightly, to use pointer's attributes rather than the awkward sounding pointing device attributes
  • added glossary definition for "measurable properties"
  • minor: in contrast with > in contrast to

Closes #375


Preview | Diff

- a user agents may coalesce events not just if the position is updated, but any of the attributes (as it's not just position changes that can result in an overwhelmingly large number of events)
- tweaked the matching sentence in the `pointerrawupdate` slightly, to use `pointer's attributes` rather than the awkward sounding `pointing device attributes`

Closes #375
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
…nstead

due to the fact that `tiltX`, `tiltY`, `twist` being `long` properties would count as discrete under the general definition.
@patrickhlauke
Copy link
Member Author

@flackr @smaug---- if you could have a look at this so far. it's not super elegant, but hopefully accurate at least. open to any better suggestions too of course.

Copy link
Member

@mustaqahmed mustaqahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The glossary entry looks good to me but please wait for a second opinion because I may be biased towards "measurable".

index.html Outdated Show resolved Hide resolved
…ogether

no need to mention them, as they don't lead to pointer events firing anyway
Copy link
Member

@mustaqahmed mustaqahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks,

I would still suggest a second review in case I am too biased towards "measurable".

Copy link
Contributor

@smaug---- smaug---- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would possibly just drop that "domain" thing

index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
@patrickhlauke
Copy link
Member Author

Agreed on call to add "continuous" as per #379 (comment) (first option) and merge.

@patrickhlauke patrickhlauke merged commit 11dd1cd into gh-pages Jul 7, 2021
@patrickhlauke patrickhlauke deleted the patrickhlauke-issue375 branch July 7, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do user agents only coalesce pointermove events relating to changes in position?
4 participants