-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Add a missing ref-name for requestPointerLock method #48
Conversation
@marcoscaceres There was another place in the spec that was referring to requestPointerLock but with no link at the moment. When I change that to |
You are probably missing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... convention is to have methods as "foo()" throughout the spec. Are you sure you want to change them?
Added data-link-for="Element" to the closest |
Convention through out this spec or across W3C specs? At least I know we haven't followed this in PointerEvent spec. Is that written somewhere so I can take a look and see how it generally applies? How does that apply to the functions with parameter? Should we just drop the parameters in links or should we mention them all every time in a link?
Yup. This fixed it. Thanks. |
W3C.
Not explicitly, but you can see examples, for instance, in the TAG's API Design Guidelines: And also in the other specs created by the WG: (open any, search for "()" to find methods)
There are a number of different ways, depending on what you prefer. Payment Request defines the methods in a <h2><dfn>show()</dfn></h2>
<p>
The <code>show(optional <var data-type="Promise">detailsPromise</var>)</code> method MUST act as follows:
</p>
<ul class="algorithm">
<!--- stuff -->
</ul> What is neat about the above is that the type information propagates in the algorithm. Alternative, if you ever need to just define a method inline with arguments: <p>
<dfn data-lt="requestPointerLock()">requestPointerLock(DOMString <var data-type="DOMString">someArg</var>)</dfn>
</p> Eventually, plan on adding support support for function parameters to the |
Fair enough. So let's follow the pattern here then. I removed my changes and also change the new reference to {{}} as from what you said it seems that will get more support and seems to be the recommended way of referencing here. |
Sounds great. Happy to review changes once new params are added. Looking forward to discussing those. |
Change the ref-name of the functions to make it
easier in the follow up changes to add parameters
Preview | Diff