Fix example 5.5 and move to ECMAScript2015 #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markafoltz
requested changes
Oct 10, 2016
| var disconnectBtn = document.getElementById("disconnectBtn"); | ||
| var stopBtn = document.getElementById("stopBtn"); | ||
| stopBtn.onclick = function () { connection && connection.terminate(); }; | ||
| let stopBtn = document.querySelector("#stopBtn"); |
There was a problem hiding this comment.
Can you use const instead of let for the *Btn variables?
| connection.onterminate(); | ||
| connection.onterminate = undefined; | ||
|
|
||
| connection.terminate(); |
There was a problem hiding this comment.
This could terminate the presentation when it's reconnected to, per example 5.3, if the old connection hasn't fired onclose yet.
If we want to guarantee that at most one connection to the presentation is open, then maybe this could be:
if (connection && connection != newConnection && connection.state != 'closed') {
connection.onclosed = undefined;
connection.close();
}
| let disconnectBtn = document.querySelector("#disconnectBtn"); | ||
|
|
||
| stopBtn.onclick = _ => { | ||
| connection && connection.terminate(); |
There was a problem hiding this comment.
I think you'll need && here and below.
There was a problem hiding this comment.
Both seems to work, but let me make the change
markafoltz
requested changes
Oct 11, 2016
|
|
||
| function setConnection(newConnection) { | ||
| // Disconnect from existing presentation, if not attempting to reconnect | ||
| if (connection && connection != newConnection && connection.state != 'closed') { |
There was a problem hiding this comment.
&& should be &&
|
To move things forward I'll merge this and submit a follow-up pull request to make any necessary further changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors in example 5.5 like missing reconnectBtn element and move to newer ECMAScript features where it makes sense.