Clarify requirements for push endpoint determinism and predictability #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
requested changes
Jun 26, 2017
There was a problem hiding this comment.
You should reference the text in RFC 8030 about this: https://tools.ietf.org/html/rfc8030#section-8.2
index.html
Outdated
| @@ -526,6 +526,13 @@ | |||
| subscription</a> MUST be <a>deactivated</a>. | |||
| </p> | |||
| <p> | |||
| The <a>push endpoint</a> MUST NOT enable information about the user to be derived by actors | |||
index.html
Outdated
| The <a>push endpoint</a> MUST NOT enable information about the user to be derived by actors | ||
| other than the <a>push service</a>, such as the user's device, identity or location. | ||
| <a>Push services</a> that do not require <a>push subscriptions</a> to be restricted to an | ||
| <a>application server</a> [[!WEBPUSH-VAPID]] MUST NOT generate predictable |
There was a problem hiding this comment.
Why is this requirement only levied on endpoints that are NOT restricted? RFC 8030 is pretty clear on this point and restriction to an application server doesn't change that.
There was a problem hiding this comment.
Good point - I've updated this to refer 8030 instead.
This also updates the [[!WEBPUSH-PROTOCOL]] references to [[!RFC8030]]. Fixes w3c#273
beverloo
force-pushed
the
security-review-feedback
branch
from
d9501cd
to
9c08033
Compare
beverloo
commented
Aug 21, 2017
index.html
Outdated
| @@ -526,6 +526,13 @@ | |||
| subscription</a> MUST be <a>deactivated</a>. | |||
| </p> | |||
| <p> | |||
| The <a>push endpoint</a> MUST NOT enable information about the user to be derived by actors | |||
index.html
Outdated
| The <a>push endpoint</a> MUST NOT enable information about the user to be derived by actors | ||
| other than the <a>push service</a>, such as the user's device, identity or location. | ||
| <a>Push services</a> that do not require <a>push subscriptions</a> to be restricted to an | ||
| <a>application server</a> [[!WEBPUSH-VAPID]] MUST NOT generate predictable |
There was a problem hiding this comment.
Good point - I've updated this to refer 8030 instead.
|
This update looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @magnus-git
Preview | Diff