Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually add "shrink-to-fit=no" to viewport meta element #31

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

gkellogg
Copy link
Member

This should be done by ReSpec, but it seems to be missing from the generated output.

@pchampin @iherman I don't know if you've encountered this before, as the only code I see in ReSpec includes this attribute, yet it was missing from the generated FPWD/Overview.html. It could come back to bite is with Echidna in the future.

… be done by ReSpec, but it seems to be missing from the generated output.
@gkellogg gkellogg merged commit 744d1a8 into main Nov 11, 2022
@gkellogg gkellogg deleted the shrink-to-fit branch November 11, 2022 19:35
@pchampin
Copy link
Contributor

I believe I found the reason of this problem:
the HTML source does contain a <meta name=viewport ...> element, so ReSpec does not add its own.
If you remove that element from the source, ReSpec will generate it with the correct value.

@gkellogg
Copy link
Member Author

Great, thanks. I’ll update this. I had created a respec issue, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants