Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update algorithm output to be the serialized canonical form #97

Merged
merged 4 commits into from
May 5, 2023

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented May 2, 2023

Update definition of "normalized dataset" to be an RDF dataset and an ordered map mapping canonical labels to blank nodes within that dataset.

Update the result of the canonicalization algorithm to be the serialized canonical form of that normalized dataset.

Fixes #4. Fixes #92.


Preview | Diff

… ordered map mapping canonical labels to blank nodes within that dataset.

Update the result of the canonicalization algorithm to be the serialized canonical form of that normalized dataset.

Fixes #4.
@peacekeeper
Copy link
Contributor

I think to complete #4, this is still missing some language about how implementations may change stable blank node identifiers before serialization, or change the order of serialized N-Quads, or something like that.

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(editorial) Fairly minor but clarifying, I think.

spec/index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@gkellogg
Copy link
Member Author

gkellogg commented May 3, 2023

I think to complete #4, this is still missing some language about how implementations may change stable blank node identifiers before serialization, or change the order of serialized N-Quads, or something like that.

I thought about that, but not sure where the wording would go. The branching point is at step 7 in the Canonicalization Algorithm. Clearly, the serializer could be called with an alternative dataset that uses a different mapping and an implementation could insert steps before step 7 to perform some operations on the normalized dataset to create such an alternative map.

spec/index.html Outdated Show resolved Hide resolved
…s blank nodes to their canonical identifiers, not the other way around.
spec/index.html Outdated Show resolved Hide resolved
@gkellogg gkellogg merged commit 7bc4143 into main May 5, 2023
@gkellogg gkellogg deleted the algo-output branch May 5, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out RDH process flow and additional outputs What is the output of the c14n algorithm?
5 participants