Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue marker for json datatype #9

Merged
merged 3 commits into from
Apr 13, 2023
Merged

Issue marker for json datatype #9

merged 3 commits into from
Apr 13, 2023

Conversation

domel
Copy link
Contributor

@domel domel commented Feb 18, 2023

Copy link
Contributor

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs discussion by the WG.

@gkellogg
Copy link
Member

Perhaps change the text on rdf:JSON to an issue marker.

@pfps
Copy link
Contributor

pfps commented Feb 18, 2023

I don't think there is even a WG issue to point to for rdf:JSON.

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am generally in favor of normatively specifying rdf:JSON (as well as rdf:HTML, rdf:YAML, and likely others). I think that addressing these should start with an issue, rather than a PR, even though discussing the language may be better handled in a PR (even this one) than an issue.

@gkellogg
Copy link
Member

gkellogg commented Feb 18, 2023

Issue #7 is what relates to this, and is what should be referenced. If there was good support for referencing wg-general issues in ReSpec that would be better, but we're left with per-repository issues. In RDF Concepts it's w3c/rdf-concepts#14.

@TallTed
Copy link
Member

TallTed commented Feb 19, 2023

There is no Issue #9 in this repo; it's PR #9, which is where I'm writing this comment. Please provide a complete link to the Issue #9 to which you refer.

I think it's legitimate to create an issue in one repo and reference it from issues on other repos, each of which then get addressed by a PR in the associated repo. This provides a clear back-and-forth reference chain from local-repo-PR to local-repo-Issue to remote-repo-Issue.

@gkellogg
Copy link
Member

There is no Issue #9 in this repo; it's PR #9, which is where I'm writing this comment. Please provide a complete link to the Issue #9 to which you refer.

Okay, a typo. Look at the list of (at this point) three open issue, it seems that it is issue #7. (GitHub suggestions when you start with '#' aren't always helpful).

@afs
Copy link
Contributor

afs commented Feb 20, 2023

should start with an issue

yes.

There has been no WG decision. Publishing in FPWD must reflect the WG.

@TallTed
Copy link
Member

TallTed commented Feb 20, 2023

[@afs] Publishing in FPWD must reflect the WG.

This is not accurate. FPWD is a heartbeat action, as are all the Editors' Drafts that get published between FPWD and CR. FPWD does require group consensus to publish, but there are no requirements about its content, which has even less weight than the content of a WG NOTE, which has almost no weight. An FPWD could be pure boilerplate, or a collection of sections that entirely disagree with each other, or a bunch of Guttenberg Project or Lorem Ipsum text.

@timothee-haudebourg timothee-haudebourg linked an issue Feb 27, 2023 that may be closed by this pull request
@pfps pfps added the needs discussion Proposed for discussion in an upcoming meeting label Mar 23, 2023
@gkellogg gkellogg self-assigned this Apr 6, 2023
@gkellogg gkellogg added spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text) and removed needs discussion Proposed for discussion in an upcoming meeting labels Apr 6, 2023
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is no just an issue marker to #7, with other text commented out for now.

Copy link
Contributor

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer something that better indicates that there is an issue about whether to add the rdf:JSON datatype, not that there is an issue to add it, which reads as if the addition is a done deal and what remains is figuring out the details.

@gkellogg
Copy link
Member

gkellogg commented Apr 6, 2023

This is substantially the same text as has been in the RDF Concepts PR w3c/rdf-concepts#18 since February. It is a pointer to the issue which has already been approved by the WG. The issue proposes to add the rdf:JSON datatype, which is in fact the issue to be determined. This is just a pointer that issue. I think we've discussed the "issue" of adding issue markers enough.

@gkellogg gkellogg added the needs discussion Proposed for discussion in an upcoming meeting label Apr 10, 2023
@pfps
Copy link
Contributor

pfps commented Apr 13, 2023

If this is to be just adding an issue marker, the title of the PR should be modified.

@gkellogg gkellogg changed the title json datatype added Issue marker for json datatype Apr 13, 2023
@domel domel merged commit ec41c71 into main Apr 13, 2023
@pfps pfps removed the needs discussion Proposed for discussion in an upcoming meeting label Apr 13, 2023
@gkellogg gkellogg deleted the json-datatype branch May 2, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the rdf:JSON datatype
5 participants