Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation syntax for Turtle* #58

Merged
merged 7 commits into from
Dec 11, 2020
Merged

Annotation syntax for Turtle* #58

merged 7 commits into from
Dec 11, 2020

Conversation

pchampin
Copy link
Collaborator

@pchampin pchampin commented Dec 9, 2020

@pchampin
Copy link
Collaborator Author

pchampin commented Dec 9, 2020

PR #10 was based on an old version of the document (when it was still called index.html), and it didn't have the preview enabled, so I preferred creating a new one.

@pchampin pchampin changed the title "manual" rebase of outdated PR #10 Annotation syntax for Turtle* Dec 10, 2020
@pchampin
Copy link
Collaborator Author

@gkellogg I requested a new review mostly for the informative note I added on SA-mode + PG-mode

@gkellogg
Copy link
Member

Yes, the updated language looks good, and we should resolve any other outstanding issues pertaining to PG-mode and SA-mode in favor of the SA interpretation of << ... >> for both Turtle* and SPARQL*.

rdf-star-cg-spec.html Outdated Show resolved Hide resolved
rdf-star-cg-spec.html Outdated Show resolved Hide resolved
rdf-star-cg-spec.html Outdated Show resolved Hide resolved
rdf-star-cg-spec.html Outdated Show resolved Hide resolved
pchampin and others added 2 commits December 11, 2020 15:55
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@@ -873,7 +873,7 @@ <h2>SA-mode and PG-mode</h2>

<ul>
<li>The <code>&lt;&lt; ... &gt;&gt;</code> syntax represents an <a>embedded triple</a> without asserting it, satisfying the need formerly filled by SA-mode.</li>
<li>The <code>{| ... |}</code> syntax creates triples where the subject is interpreted as an <a>embedded</a> version of the triple previously requiring distinct <a>assertion</a>, without the need to repeat it, satisfying the need formerly filled by PG-mode.</li>
<li>The <code>{| ... |}</code> syntax (annotation) creates triples where the subject is interpreted as an <a>embedded</a> version of the triple <a>asserted</a> just before the annotation, without the need to repeat it, satisfying the need formerly filled by PG-mode.</li>
Copy link
Member

@TallTed TallTed Dec 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>The <code>{| ... |}</code> syntax (annotation) creates triples where the subject is interpreted as an <a>embedded</a> version of the triple <a>asserted</a> just before the annotation, without the need to repeat it, satisfying the need formerly filled by PG-mode.</li>
<li>The <code>{| ... |}</code> annotation syntax creates triples where the subject is interpreted as <a>asserting</a> the triple <a>embedded</a> just before the annotation, without the need to repeat it (i.e., to explicitly assert it), satisfying the need formerly filled by PG-mode.</li>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what's trying to be said is not 100% clear, so I'm not sure this says it ... but I think it's closer than it started.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sorry, I think we are getting further from what I'm trying to say (but this is cumbersome to put in prose).

:a :b :c {| :p1 :o1; :p2 :o2 |}

The annotation is the {| ... |} part. The triple :a :b :c is asserted, as it would be if there was no annotation. What the annotation is doing is creating triples X :p1 :o1 and X :p2 :o2, where X is << :a :b :c >>, an embedded version of :a :b :c, the triple asserted just before the annotation.

I think the "is interpreted as" is confusing and should be removed. I also agree that getting "annotation" out of parenthesis is better. Finally, I'll add :p :o inside the annotation syntax example, to hint at the fact that it contains predicate-object pairs, but no explicit subject.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TallTed what do you think now?

rdf-star-cg-spec.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@pchampin
Copy link
Collaborator Author

This was discussed in today's call: https://w3c.github.io/rdf-star/Minutes/2020-12-11.html#item05

@pchampin pchampin merged commit f1bb43d into main Dec 11, 2020
<p>The notion of <a href="#grammar-production-annotation">annotations</a> in the <a href="#turtle-star">Turtle*</a> syntax was introduced to remove the need for different modes. Rather than interpret the same syntax differently in each mode, which would have caused interoperability problems and required a switch for those modes, it was decided to provide a different syntax for each use case.</p>

<ul>
<li>The <code>&lt;&lt; ... &gt;&gt;</code> syntax represents an <a>embedded triple</a> without asserting it, satisfying the need formerly filled by SA-mode.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>The <code>&lt;&lt; ... &gt;&gt;</code> syntax represents an <a>embedded triple</a> without asserting it, satisfying the need formerly filled by SA-mode.</li>
<li>The <code>&lt;&lt; ... &gt;&gt;</code> syntax represents a triple that is <a>embedded</a> without being <a>asserted</a>, satisfying the need formerly filled by SA-mode.</li>

@TallTed
Copy link
Member

TallTed commented Dec 11, 2020

@pchampin -- I think we're getting closer. I've tweaked both paragraphs. See what you think?

@TallTed
Copy link
Member

TallTed commented Dec 11, 2020

Oops ... missed the merge.

hartig added a commit that referenced this pull request Dec 11, 2020
…e lines of #58; first step to address the SPARQL* part of #9
pchampin pushed a commit that referenced this pull request Dec 14, 2020
last tweak to #58, which was suggested after commit
@gkellogg gkellogg deleted the annotations2 branch November 13, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants