Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C14N tests #111

Merged
merged 17 commits into from
Oct 19, 2023
Merged

C14N tests #111

merged 17 commits into from
Oct 19, 2023

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Aug 2, 2023

(N-Triples for right now).

  • N-Triples canonicalization tests based on 1.1 syntax tests.
  • Remove ending newline in C14N minimal whitespace tests.
  • Adds tests with extra whitespace.
  • Add canonicalization of literal with explicit xsd:string.
  • HTML version of C14N manifest.

TallTed
TallTed suggested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things

rdf/rdf12/rdf-n-triples/README.md Outdated Show resolved Hide resolved
@gkellogg gkellogg mentioned this pull request Aug 10, 2023
Closed
@gkellogg gkellogg marked this pull request as ready for review October 16, 2023 18:54
@gkellogg
Copy link
Member Author

Better get this merged for N-Triples now; we can add more, and add C14N tests for N-Quads later.

@gkellogg gkellogg requested a review from TallTed October 16, 2023 23:44
TallTed
TallTed suggested changes Oct 16, 2023
View reviewed changes
rdf/rdf11/template.haml Outdated Show resolved Hide resolved
rdf/rdf12/template.haml Outdated Show resolved Hide resolved
rdf/template.haml Outdated Show resolved Hide resolved
@TallTed
Copy link
Member

TallTed commented Oct 16, 2023

I think my spelling corrections are now suggested on the correct files...

@gkellogg @TallTed
Apply suggestions from code review
771a8ac 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@gkellogg gkellogg requested a review from TallTed October 17, 2023 15:56
Tpt added a commit to oxigraph/oxigraph that referenced this pull request Oct 18, 2023
@Tpt
Draft: Testsuite: executes C14N tests
d0ab576 
w3c/rdf-tests#111
@Tpt Tpt mentioned this pull request Oct 18, 2023
Merged
Tpt
Tpt approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Tpt Tpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Tested with Oxigraph

rdf/rdf12/rdf-n-triples/README.md Outdated Show resolved Hide resolved
Tpt added a commit to oxigraph/oxigraph that referenced this pull request Oct 19, 2023
@Tpt
Draft: Testsuite: executes C14N tests
d2bc58e 
w3c/rdf-tests#111
@gkellogg gkellogg merged commit 59b0496 into main Oct 19, 2023
@gkellogg gkellogg deleted the c14n-tests branch October 19, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tpt Tpt Tpt approved these changes

@TallTed TallTed TallTed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gkellogg @TallTed @Tpt