Add missing definitions, fix ReSpec & validator warnings #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following ReSpec warnings: No <dfn> for RemotePlayback. No <dfn> for RemotePlaybackState. No <dfn> for RemotePlaybackAvailabilityCallback. pre elements don't need a 'highlight' class anymore.
<a for> -> <a data-link-for> <dfn for> -> <dfn data-dfn-for> See: https://github.com/w3c/respec/wiki/data-link-for https://github.com/w3c/respec/wiki/data-dfn-for
mounirlamouri
approved these changes
Feb 21, 2017
index.html
Outdated
| @@ -440,129 +498,184 @@ | |||
|
|
|||
| callback RemotePlaybackAvailabilityCallback = void(boolean available); | |||
| </pre> | |||
| <p> | |||
| A <dfn>RemotePlayback</dfn> object represents a <a>remote playback | |||
| device</a>. | |||
There was a problem hiding this comment.
I'm not sure about that but I will let @avayvod decide :)
There was a problem hiding this comment.
Right, I will defer to the editors on the proper definition of this thing :-)
There was a problem hiding this comment.
I'd rather say something like: A RemotePlayback object is an interface allowing the page to detect, establish connection to and control playback on remote playback devices.
|
@avayvod any concerns in merging this PR? |
|
Modulo the definition of RemotePlayback object, lgtm. |
|
Please push your fix to this branch and merge. |
avayvod
approved these changes
Feb 23, 2017
|
Thanks for taking care of this, Anssi! @anssiko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL @mounirlamouri @avayvod
Btw. The spec is on TAG's agenda for tomorrow -- this PR adds some polish to it :-)