Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The step to queue a task to run fire a buffer full event should specify its source #215

Closed
rniwa opened this issue Oct 10, 2019 · 2 comments · Fixed by #232
Closed

The step to queue a task to run fire a buffer full event should specify its source #215

rniwa opened this issue Oct 10, 2019 · 2 comments · Fixed by #232
Assignees
@yoavweiss
Labels
hackathon_15_09_20 hackathon_2020
Milestone
Level 2

Comments

@rniwa
Copy link

rniwa commented Oct 10, 2019

Queueing a task requires specifying its source. We need to specify one for when we schedule a task to fire a buffer full event.
@npm1
Copy link
Contributor

npm1 commented Jan 21, 2020

In https://w3c.github.io/performance-timeline/#queue-a-performanceentry we use the 'performance timeline task source'. We should use that task source here.

@yoavweiss yoavweiss self-assigned this Jan 30, 2020
@nicjansma nicjansma added this to the Level 2 milestone May 19, 2020
npm1 added a commit to w3c/performance-timeline that referenced this issue Sep 15, 2020
@npm1
Add dfn to performance timeline task source
318355d 
This enables linking to it from other specifications. In particular this will be used in ResourceTiming for the buffer full task: w3c/resource-timing#215
@npm1 npm1 mentioned this issue Sep 15, 2020
Merged
npm1 added a commit that referenced this issue Sep 15, 2020
@npm1
Add task source to queue a task
8dad5e5 
Fixes #215
@npm1 npm1 mentioned this issue Sep 15, 2020
Merged
@npm1 npm1 closed this as completed in #232 Sep 15, 2020
@rniwa
Copy link
Author

rniwa commented Sep 16, 2020

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoavweiss yoavweiss

Labels
hackathon_15_09_20 hackathon_2020
Projects
None yet
Milestone
Level 2
Development

Successfully merging a pull request may close this issue.

Add task source to queue a task w3c/resource-timing
4 participants
@rniwa @yoavweiss @nicjansma @npm1