Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task source to queue a task #232

Merged
merged 2 commits into from Sep 15, 2020
Merged

Add task source to queue a task #232

merged 2 commits into from Sep 15, 2020

Conversation

npm1
Copy link
Contributor

@npm1 npm1 commented Sep 15, 2020

Fixes #215


Preview | Diff

@npm1 npm1 requested a review from yoavweiss September 15, 2020 14:02
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit and otherwise LGTM

index.html Outdated
<li>Queue a task to run <a>fire a buffer full event</a>.</li>
<li><a>Queue a task</a> on the <a href=
"https://w3c.github.io/performance-timeline/#dfn-performance-timeline-task-source">performance
timeline task source</a> test to run <a>fire a buffer full event</a>.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"test" here seems unrelated...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I was testing something... thanks for catching it

@npm1 npm1 merged commit ada912e into gh-pages Sep 15, 2020
@npm1 npm1 deleted the queue-task-source branch September 15, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The step to queue a task to run fire a buffer full event should specify its source
2 participants