Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection reuse does not imply DNS was not required #185

Merged
merged 2 commits into from
Dec 19, 2018
Merged

Connection reuse does not imply DNS was not required #185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7162c69
Connection reuse does not imply DNS was not required
yoavweiss Dec 18, 2018
78bd09f
Review comments
yoavweiss Dec 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 13 additions & 11 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,11 +524,12 @@ <h3>The <dfn>PerformanceResourceTiming</dfn> Interface</h3>
<p data-dfn-for="PerformanceResourceTiming">On getting, the
<dfn>domainLookupStart</dfn> attribute MUST return as follows:</p>
<ol data-link-for="PerformanceResourceTiming">
<li>The same value as <a>fetchStart</a>, if a <a href=
<li>The same value as <a>fetchStart</a>, if no domain lookup was
required to fetch the resources (e.g. if a <a href=
"https://tools.ietf.org/html/RFC7230#section-6.3">persistent
connection</a> [[RFC7230]] is used or the resource is retrieved
from <a data-cite="HTML#relevant-application-cache">relevant
application caches</a> or local resources.</li>
connection</a> [[RFC7230]] was used or in case the resource was
retrieved from <a data-cite="HTML#relevant-application-cache">relevant
application caches</a> or local resources).</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also need this change the other places we mention "persistent connection"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all of them, but I did leave out domainLookupEnd...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. PTAL?

<li>The time immediately after the user agent before the domain
data retrieval from the domain information cache, if the user agent
has the domain information in cache.</li>
Expand All @@ -541,15 +542,16 @@ <h3>The <dfn>PerformanceResourceTiming</dfn> Interface</h3>
<p data-dfn-for="PerformanceResourceTiming">On getting, the
<dfn>domainLookupEnd</dfn> attribute MUST return as follows:</p>
<ol data-link-for="PerformanceResourceTiming">
<li>The same value as <a>fetchStart</a>, if a <a data-cite=
"RFC7230#section-6.3">persistent connection</a> [[RFC7230]] is used
or the resource is retrieved from <a data-cite=
"HTML#relevant-application-cache">relevant application caches</a>
or local resources.</li>
<li>The same value as <a>fetchStart</a>, if no domain lookup was
required to fetch the resources (e.g. if a <a href=
"https://tools.ietf.org/html/RFC7230#section-6.3">persistent
connection</a> [[RFC7230]] was used or in case the resource was
retrieved from <a data-cite="HTML#relevant-application-cache">relevant
application caches</a> or local resources).</li>
<li>The time immediately after the user agent ends the domain data
retrieval from the domain information cache, if the user agent has
the domain information in cache.</li>
<li>The time immediately before the user agent finishes the domain
<li>The time immediately after the user agent finishes the domain
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by fixing this

name lookup for the resource, if the last non-redirected
<a data-cite="FETCH#concept-fetch">fetch</a> of the resource passes
the <a>timing allow check</a> algorithm.</li>
Expand Down Expand Up @@ -1063,7 +1065,7 @@ <h3>Processing Model</h3>
"https://tools.ietf.org/html/rfc7234">HTTP cache</a> [[RFC7234]],
go to step <a href="#dfn-step-request-start">14</a>.</li>
<li>If no domain lookup is required, go to step <a href=
"#dfn-step-connect-start">12</a>. Otherwise, immediately before a
"#dfn-step-connect-start">14</a>. Otherwise, immediately before a
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by fix

user agent starts the domain name lookup, record the time as
<a>domainLookupStart</a>.</li>
<li>Record the time as <a>domainLookupEnd</a> immediately after the
Expand Down