Connection reuse does not imply DNS was not required #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvazac
reviewed
Dec 19, 2018
index.html
Outdated
| @@ -524,11 +524,12 @@ <h3>The <dfn>PerformanceResourceTiming</dfn> Interface</h3> | |||
| <p data-dfn-for="PerformanceResourceTiming">On getting, the | |||
| <dfn>domainLookupStart</dfn> attribute MUST return as follows:</p> | |||
| <ol data-link-for="PerformanceResourceTiming"> | |||
| <li>The same value as <a>fetchStart</a>, if a <a href= | |||
| <li>The same value as <a>fetchStart</a>, if no domain lookup was | |||
| required to fetch the resources (e.g. due to the fact that a <a href= | |||
| application caches</a> or local resources.</li> | ||
| connection</a> [[RFC7230]] was used or in case the resource was | ||
| retrieved from <a data-cite="HTML#relevant-application-cache">relevant | ||
| application caches</a> or local resources).</li> |
There was a problem hiding this comment.
do we also need this change the other places we mention "persistent connection"?
There was a problem hiding this comment.
Not all of them, but I did leave out domainLookupEnd...
yoavweiss
commented
Dec 19, 2018
| <li>The time immediately after the user agent ends the domain data | ||
| retrieval from the domain information cache, if the user agent has | ||
| the domain information in cache.</li> | ||
| <li>The time immediately before the user agent finishes the domain | ||
| <li>The time immediately after the user agent finishes the domain |
There was a problem hiding this comment.
Drive-by fixing this
yoavweiss
commented
Dec 19, 2018
| @@ -1063,7 +1065,7 @@ <h3>Processing Model</h3> | |||
| "https://tools.ietf.org/html/rfc7234">HTTP cache</a> [[RFC7234]], | |||
| go to step <a href="#dfn-step-request-start">14</a>.</li> | |||
| <li>If no domain lookup is required, go to step <a href= | |||
| "#dfn-step-connect-start">12</a>. Otherwise, immediately before a | |||
| "#dfn-step-connect-start">14</a>. Otherwise, immediately before a | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160
As discussed on the call, this is not currently testable in WPT infrastructure. I'm planning to open an issue to keep track of tests for this.
Preview | Diff