Change nextHopProtocol to a ByteString #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavweiss
approved these changes
Jul 7, 2021
| connection timing info</a> for more info. | ||
| decode=] <a>this</a>'s [=PerformanceResourceTiming/timing info=]'s | ||
| [=fetch timing info/final connection timing info=]'s [=connection | ||
| timing info/ALPN negotiated protocol=]. See <a data-cite= |
There was a problem hiding this comment.
Can we also drop the data-cite here?
There was a problem hiding this comment.
Possibly, but it's explicitly marked as a "private" definition (noexport) by Fetch. @annevk, not sure if you want to export that? Do you have a suggestion of what we could link to?
There was a problem hiding this comment.
OK, let's not block on it then. We can open a separate issue for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #277
Recreated #277 because of all the conflicts.
Preview | Diff