Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change nextHopProtocol to a ByteString #281

Merged
merged 1 commit into from Jul 9, 2021
Merged

Change nextHopProtocol to a ByteString #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions index.html
View file
Open in desktop
Expand Up @@ -416,7 +416,7 @@ <h3>
[Exposed=(Window,Worker)]
interface PerformanceResourceTiming : PerformanceEntry {
readonly attribute DOMString initiatorType;
readonly attribute DOMString nextHopProtocol;
readonly attribute ByteString nextHopProtocol;
readonly attribute DOMHighResTimeStamp workerStart;
readonly attribute DOMHighResTimeStamp redirectStart;
readonly attribute DOMHighResTimeStamp redirectEnd;
Expand Down Expand Up @@ -592,11 +592,11 @@ <h3>
</p>
<p data-dfn-for="PerformanceResourceTiming">
The <dfn>nextHopProtocol</dfn> getter steps are to [=/isomorphic
decode=] <a>this</a>'s <a data-for="PerformanceResourceTiming">timing
info</a>'s [=fetch timing info/final connection timing info=]'s
[=connection timing info/ALPN negotiated protocol=]. See
<a data-cite="FETCH#record-connection-timing-info">Recording
connection timing info</a> for more info.
decode=] <a>this</a>'s [=PerformanceResourceTiming/timing info=]'s
[=fetch timing info/final connection timing info=]'s [=connection
timing info/ALPN negotiated protocol=]. See <a data-cite=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also drop the data-cite here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, but it's explicitly marked as a "private" definition (noexport) by Fetch. @annevk, not sure if you want to export that? Do you have a suggestion of what we could link to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's not block on it then. We can open a separate issue for this

"FETCH#record-connection-timing-info">Recording connection timing
info</a> for more info.
</p>
<p data-dfn-for="PerformanceResourceTiming">
The <dfn>requestStart</dfn> getter steps are to <a>convert fetch
Expand Down