fix(core/webidl-contiguous): generate valid fragments (closes #1120)

w3c · Mar 7, 2017 · 0ed7ac5 · 0ed7ac5
1 parent 590377e
commit 0ed7ac5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/js/core/webidl-contiguous.js b/js/core/webidl-contiguous.js
@@ -898,9 +898,7 @@ define(
               defn.arguments.filter(function(arg) {
                 return !typeIsWhitespace(arg.type);
               }).map(function(arg) {
-                var optional = arg.optional ? "optional-" : "";
-                var variadic = arg.variadic ? "..." : "";
-                return optional + idlType2Text(arg.idlType).toLowerCase() + variadic;
+                return arg.name.toLowerCase();
               }).join(",").replace(/\s/g, "_") + ")");
             break;
           case "maplike":

diff --git a/tests/spec/core/webidl-contiguous-spec.js b/tests/spec/core/webidl-contiguous-spec.js
@@ -397,8 +397,7 @@ describe("Core - Contiguous WebIDL", function() {
     expect(ulls.last().children("a").attr("href"))
       .toEqual("#dom-methbasic-ull!overload-1");
     expect($target.find(".idlMethod:contains('paramed')").attr("id"))
-      .toEqual("idl-def-methbasic-paramed(superstar[][]?[],bytestring?,optional-short," +
-        "short[],short[][][][],optional-short,optional-domstring,short...)");
+      .toEqual("idl-def-methbasic-paramed(one,ext,maybe,shorts,hypercubes,defaulted,defaulted2,variable)");
     expect($target.find(":contains('dates')").filter("a").length)
       .toEqual(0);
     done();