fix(core/webidl): pad static methods

* closes #1559
w3c · Mar 10, 2018 · d47417a · d47417a
1 parent ec12659
commit d47417a
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/src/core/webidl.js b/src/core/webidl.js
@@ -586,11 +586,16 @@ function writeInterfaceDefinition(opt, fixes = {}) {
     var len = idlType2Text(it.idlType).length;
     if (it.type === "attribute") {
       var qualifiersLen = writeAttributeQualifiers(it).length;
-      maxAttr = len > maxAttr ? len : maxAttr;
-      maxAttrQualifiers =
-        qualifiersLen > maxAttrQualifiers ? qualifiersLen : maxAttrQualifiers;
-    } else if (it.type === "operation") maxMeth = len > maxMeth ? len : maxMeth;
-    else if (it.type === "const") maxConst = len > maxConst ? len : maxConst;
+      maxAttr = Math.max(len, maxAttr);
+      maxAttrQualifiers = Math.max(qualifiersLen, maxAttrQualifiers);
+    } else if (it.type === "operation") {
+      if (it.static) {
+        len += "static ".length;
+      }
+      maxMeth = Math.max(len, maxMeth);
+    } else if (it.type === "const") {
+      maxConst = Math.max(len, maxConst);
+    }
   }
   var children = obj.members
     .map(function(ch) {
@@ -672,13 +677,11 @@ function writeMethod(meth, max, indent) {
     });
   var params = paramObjs.join(", ");
   var len = idlType2Text(meth.idlType).length;
-  if (meth.static) len += 7;
   var specialProps = [
     "getter",
     "setter",
     "deleter",
-    "legacycaller",
-    "stringifier",
+    "static", // not "special op", but serves same role
   ];
   var special = "";
   for (var i in specialProps) {
@@ -692,7 +695,6 @@ function writeMethod(meth, max, indent) {
   var methObj = {
     obj: meth,
     indent: indent,
-    static: meth.static ? "static " : "",
     special: special,
     pad: pad,
     children: params,