Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReSpec should warn on unstructured/text specref entries #1082

Closed
riannella opened this issue Feb 16, 2017 · 16 comments
Closed

ReSpec should warn on unstructured/text specref entries #1082

riannella opened this issue Feb 16, 2017 · 16 comments
Labels

Comments

@riannella
Copy link

For some strange reason, 2 references are not working in our document:
http://w3c.github.io/poe/vocab/#informative-references

They are [[iso3166]] and [[iso8601]]

And I tried "ISO" as well..

any ideas?

@marcoscaceres
Copy link
Member

How odd... having a quick look.

@marcoscaceres
Copy link
Member

I'm not able to reproduce locally, so will need to dig a little deeper. However, the "nanotabs" script is generating errors which maybe related.

First error:

Mixed Content: The page at 'https://w3c.github.io/poe/vocab/#informative-references' was loaded over HTTPS, but requested an insecure script 'http://www.w3.org/scripts/nanotabs/0.9/nanotabs.js'. This request has been blocked; the content must be served over HTTPS.

Sent a PR. Let's check again once that goes in.

@riannella
Copy link
Author

Ok...I've removed the nanotabs script (as we don't use it anymore).
Issue remains...I might have to add the references to the local biblio?

@marcoscaceres
Copy link
Member

Ok...I've removed the nanotabs script (as we don't use it anymore).

Ok, thanks for eliminating that.

I might have to add the references to the local biblio?

Local biblio is empty.

Still trying to see where else that reference is getting lost and why.

@marcoscaceres
Copy link
Member

(as a temporary fix, adding it to localBiblio might fix it :) )

@marcoscaceres
Copy link
Member

Ah, I see what's happened. I forgot that we have these references as unstructured text - so when it gets added to the references database it gets converted into an object... which is kinda amusing:

screenshot 2017-02-16 13 07 56

As we don't want to support unstructured data in SpecRef anymore, we should fix this there.

BRB...

@marcoscaceres
Copy link
Member

Ok, will add the following to spec ref.

  "ISO3166": {
    "authors": [""],
    "date": "",
    "href": "http://www.iso.org/iso/home/standards/country_codes.htm",
    "publisher": "ISO",
    "status": "",
    "title": "ISO 3166: Codes for the representation of names of countries and their subdivisions."
  },
  "ISO8601": {
    "authors": [""],
    "date": "",
    "href": "http://www.iso.org/iso/catalogue_detail?csnumber=40874",
    "publisher": "ISO",
    "status": "",
    "title": "Representation of dates and times. ISO 8601:2004."
  },

@marcoscaceres marcoscaceres changed the title Two refs not working ReSpec should warn on unstructured/text specref entries Feb 16, 2017
@riannella
Copy link
Author

here's an update:

    "iso3166": {
        title: "Codes for the representation of names of countries and their subdivisions",
        publisher: "International Organization for Standardization (ISO)",
        status: "ISO 3166-1:2013",
        date: "2013",
        href: "http://www.iso.org/iso/catalogue_detail?csnumber=63545"
    },
    "iso8601": {
        title: "Representation of dates and times",
        publisher: "International Organization for Standardization (ISO)",
        status: "ISO 8601:2004",
        date: "2004",
        href: "http://www.iso.org/iso/catalogue_detail?csnumber=40874"
    }

@marcoscaceres
Copy link
Member

@riannella thanks! Will add those now.

@marcoscaceres
Copy link
Member

@riannella sent PR... just need @tobie to help me with something there:
tobie/specref#330

For other legacy entries, you can use this tool to generate them:
http://marcoscaceres.github.io/bib_entry_maker/

@marcoscaceres
Copy link
Member

Anyway, that should fix the entries... I'll update ReSpec to warn when a legacy entry type is encountered to encourage authors to update those.

@riannella
Copy link
Author

great, thanks for your help @marcoscaceres

@marcoscaceres
Copy link
Member

@riannella, after we merge, you will need to do a "hard reload" of the spec in the browser to get the broken entries to show up - otherwise, they should fix themselves after 24 hours (I make ReSpec refresh the spec's database once a day - or when it detects things have been updated on the server - in the background).

@marcoscaceres
Copy link
Member

Ok, they are working again 🎉
screenshot 2017-02-16 14 10 53

@riannella
Copy link
Author

Yeah..thanks...Now to get the title listed first #857 👍

@marcoscaceres
Copy link
Member

agree... what's there is pretty terrible. Might just fix that without doing the custom styles.

marcoscaceres added a commit that referenced this issue Feb 16, 2017
* develop:
  v10.1.9
  fix(respec2.css): adapt better to mobile (closes #755)
  fix: error if bad specref entry found (closes #1082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants