Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respec borken in Edge 15? #1258

Closed
plehegar opened this issue Jun 8, 2017 · 4 comments
Closed

respec borken in Edge 15? #1258

plehegar opened this issue Jun 8, 2017 · 4 comments
Labels

Comments

@plehegar
Copy link
Member

plehegar commented Jun 8, 2017

@jdsmith3000 reported having troubles with respec. It appears that it is broken in Edge 15:
[[
Current window: w3c.github.io/hr-time
TypeError: Unable to get property 'entries' of undefined or null reference
respec-w3c-common (1,470257)
{
[functions]: ,
proto: { },
description: "Unable to get property 'entries' of undefined or null reference",
message: "Unable to get property 'entries' of undefined or null reference",
name: "TypeError",
number: -2146823281,
stack: "TypeError: Unable to get property 'entries' of undefined or null reference
at n (https://www.w3.org/Tools/respec/respec-w3c-common:1:40854)
at n (https://www.w3.org/Tools/respec/respec-w3c-common:1:30600)
at Anonymous function (https://www.w3.org/Tools/respec/respec-w3c-common:1:30289)
at Array.prototype.forEach (native code)
at t (https://www.w3.org/Tools/respec/respec-w3c-common:1:30234)
at Anonymous function (https://www.w3.org/Tools/respec/respec-w3c-common:1:49603)
at n (https://www.w3.org/Tools/respec/respec-w3c-common:1:31225)
at Anonymous function (https://www.w3.org/Tools/respec/respec-w3c-common:1:32345)
at e[t] (https://www.w3.org/Tools/respec/respec-w3c-common:1:31398)
at r (https://www.w3.org/Tools/respec/respec-w3c-common:1:48892)"
}
]]

with Edge/15.15063.

@plehegar plehegar added the bug label Jun 8, 2017
@marcoscaceres
Copy link
Member

Thanks, will take a look first thing tomorrow

@marcoscaceres
Copy link
Member

confirmed... Edge doesn't implement URLSearchParam... adding a polyfill.

marcoscaceres added a commit that referenced this issue Jun 13, 2017
* develop:
  v14.0.3
  tests: allow testing in Edge (#1271)
  refactor: remove fetch poly (#1270)
  fix: add URLSearchParams poly (closes #1258) (#1269)
@jdsmith3000
Copy link

Tried it just now. Worked fine.

@marcoscaceres
Copy link
Member

Excellent to hear. I've also updated the test suite so it works better with Edge. Edge has several limitations that don't allow us to test it using continuous integration - so if other stuff breaks in the future, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants