Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: Preface / Editors / Boilerplate / etc section missing #1290

Closed
awoods opened this issue Jun 21, 2017 · 9 comments
Closed

Breaking Change: Preface / Editors / Boilerplate / etc section missing #1290

awoods opened this issue Jun 21, 2017 · 9 comments

Comments

@awoods
Copy link

awoods commented Jun 21, 2017

As of 7e28f11 the prefatory information is missing.

Was this change intentional? If not, it appears to be a critical bug... or are there release notes that I am missing?

@marcoscaceres
Copy link
Member

Do you have a link to the spec being affected? Not intentional.

@awoods
Copy link
Author

awoods commented Jun 21, 2017

http://fedora.info/spec/

@marcoscaceres
Copy link
Member

@awoods, thanks! Will get that fixed for you.

@marcoscaceres
Copy link
Member

Ok, PR incoming... it was crashing because of missing alt: attribute on the logo :) You might want to add a alt, width, and height.

Also, I guess you don't want the w3c logo if it's unofficial, right?

@awoods
Copy link
Author

awoods commented Jun 21, 2017

Thanks, I will update the logo. As for the w3c... either way is fine.

@marcoscaceres
Copy link
Member

I'm sending a separate PR for making the w3c logo go away.

Just waiting for TravisCI.... SOOO SLLLOOOWW TODAY!!!!!

@awoods
Copy link
Author

awoods commented Jun 22, 2017

Thanks for the help with this, @marcoscaceres .
Do you have any idea why the title is now squished off to the left?
http://fedora.info/spec/

@marcoscaceres
Copy link
Member

I think it's just that the fedora logo is a bit too large. We designed the template to only accommodate small logos. Try setting the logo to around 70px in height.

@awoods
Copy link
Author

awoods commented Jun 22, 2017

Much better.
http://fedora.info/spec/
Thanks again, @marcoscaceres .

barmintor pushed a commit to barmintor/fcrepo-specification that referenced this issue May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants