Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github links should include link to pull requests #1373

Closed
marcoscaceres opened this issue Aug 28, 2017 · 4 comments
Closed

Github links should include link to pull requests #1373

marcoscaceres opened this issue Aug 28, 2017 · 4 comments

Comments

@marcoscaceres
Copy link
Member

I keep having to click on the issues link to get to the pull requests... it's getting a little boring.

@OrionStar25
Copy link
Contributor

Hey, I'd like to work on this issue! Can you please elaborate a bit more though?

@marcoscaceres
Copy link
Member Author

@OrionStar25 that's great, and should be pretty easy.

See the screenshot below of what is actually needed:

screenshot_2018-02-08_13_19_00

You basically just need to add one of these objects here:
https://github.com/w3c/respec/blob/develop/src/core/github.js#L117

And add the localization string in English here:
https://github.com/w3c/respec/blob/develop/src/core/l10n.js#L19

And then add a test to check that the value showed up in "tests/spec/core/github-spec.js".

@marcoscaceres
Copy link
Member Author

@OrionStar25, if you haven't already, please also see the get started guide for devs https://github.com/w3c/respec/wiki/Developers-Guide

OrionStar25 added a commit to OrionStar25/respec that referenced this issue Feb 9, 2018
@OrionStar25
Copy link
Contributor

OrionStar25 commented Feb 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants