Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code samples should not be set to aria-live="polite" after core/highlight executes #1456

Closed
majornista opened this issue Jan 23, 2018 · 1 comment
Labels

Comments

@majornista
Copy link

This is a regression for a7394e3, which presents a significant accessibility problem for screen reader users trying to read a spec containing a lot of code examples, because every code sample is sent to the the screen reader buffer to announce at its earliest convenience.

I've sometimes been unable to test a page using VoiceOver with a W3C spec open in another tab, because all I hear are source code examples from the spec being announced.

@marcoscaceres
Copy link
Member

Ah yeah, got wrong advice it seems. Will remove.

marcoscaceres added a commit that referenced this issue Jan 30, 2018
* develop:
  v19.0.2
  ally: don't announce body changed
  fix: dont announce highlights (closes #1456)
  docs(README): combine buttons on one line
  docs(README): add link to developer guide
  chore(package): update mocha to version 5.0.0
  fix(package): update command-line-args to version 5.0.0
  chore(package): update http-server to version 0.11.0
  refactor(ui): rearrange/reword menu items
  fix(ui/dfn-list): broken fragments
  style(core/ui): prettier + cleanup
  refactor(core/remove-respec): remove redudant module
  refactor(js/profile-w3c-common): use async/await
  refactor(core/base-runner): fold in core/remove-respec
  refactor(core/highlight): remove redundant things
  chore(package): update karma to version 2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants