Test failure: 'root' is deprecated, use 'global'

[saschanaz]

https://travis-ci.org/w3c/respec/jobs/335038255

Not sure what happened there...

[saschanaz]

ReSpec error: (node:6910) DeprecationWarning: 'root' is deprecated, use 'global'

This seems the cause. Strangely, I rollbacked to the last known good commit and it still happens there.

[saschanaz]

I think I got the cause. cc: @nileshgulia1

handlebars.js from dependencies starts with:

(function webpackUniversalModuleDefinition(root, factory) {
	if(typeof exports === 'object' && typeof module === 'object')
		module.exports = factory();
	else if(typeof define === 'function' && define.amd)
		define([], factory);
	else if(typeof exports === 'object')
		exports["Handlebars"] = factory();
	else
		root["Handlebars"] = factory();
})(this, function() {

Here, the UMD exporting code uses a variable root. Our build system somehow converts it to:

root = this,
factory = function() { /* ... */ },
"object" == typeof exports && "object" == typeof module ? module.exports = factory() : "function" == typeof define && define.amd ? define("handlebars.runtime", [], factory) : "object" == typeof exports ? exports.Handlebars = factory() : root.Handlebars = factory(),

This made Node.js angry where root is a deprecated alias of global.

[saschanaz]

Still I have no idea why this is suddenly a problem, and only a problem for the last test.

[nileshgulia1]

Nice work @saschanaz I'll try to figure out the rest.

[saschanaz]

Generated build result is different with the one in main repo, probably affected by some change in the dependencies. (The released code does not include root=this.)

[marcoscaceres]

Just fyi, I’m in the middle of moving house, so will be a bit slow to respond to things till next week! Thanks nonetheless for looking into it.

[saschanaz]

Oops, I was just to request uploading your local package-lock.json to see what update causes this issue 😄

It seems yarn.lock is now too old.

[marcoscaceres]

Yeah, sorry there is both... npm 5 was... not a great release... so I had to switch between yarn and npm a few times.

[saschanaz]

No worry, I got a fix 😁 #1461